Return-Path: Delivered-To: apmail-maven-archiva-dev-archive@locus.apache.org Received: (qmail 45298 invoked from network); 22 Oct 2007 00:42:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Oct 2007 00:42:56 -0000 Received: (qmail 64473 invoked by uid 500); 22 Oct 2007 00:42:43 -0000 Delivered-To: apmail-maven-archiva-dev-archive@maven.apache.org Received: (qmail 64426 invoked by uid 500); 22 Oct 2007 00:42:43 -0000 Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: archiva-dev@maven.apache.org Delivered-To: mailing list archiva-dev@maven.apache.org Received: (qmail 64417 invoked by uid 99); 22 Oct 2007 00:42:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 21 Oct 2007 17:42:43 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of oching@exist.com designates 209.85.146.182 as permitted sender) Received: from [209.85.146.182] (HELO wa-out-1112.google.com) (209.85.146.182) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2007 00:42:44 +0000 Received: by wa-out-1112.google.com with SMTP id v33so1103442wah for ; Sun, 21 Oct 2007 17:42:22 -0700 (PDT) Received: by 10.114.111.1 with SMTP id j1mr4752381wac.1193013741939; Sun, 21 Oct 2007 17:42:21 -0700 (PDT) Received: from ?121.97.195.47? ( [121.97.195.47]) by mx.google.com with ESMTPS id k24sm7899011waf.2007.10.21.17.42.19 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 21 Oct 2007 17:42:20 -0700 (PDT) Message-ID: <471BF1F0.20501@exist.com> Date: Mon, 22 Oct 2007 08:42:24 +0800 From: Maria Odea Ching User-Agent: Thunderbird 1.5.0.13 (X11/20070824) MIME-Version: 1.0 To: archiva-dev@maven.apache.org Subject: Re: svn commit: r586919 - in /maven/archiva/trunk: archiva-base/archiva-consumers/archiva-database-consumers/src/main/java/org/apache/maven/archiva/consumers/database/ archiva-database/src/main/java/org/apache/maven/archiva/database/ archiva-database/src/m... References: <20071021173010.BD08B1A9832@eris.apache.org> <74DEE571-AA04-4AFE-91DF-F68D5BC05104@apache.org> In-Reply-To: <74DEE571-AA04-4AFE-91DF-F68D5BC05104@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi Brett, I thought that if there was a problem cleaning up the repository data, the delete of the repo shouldn't proceed.. or should it? :-) Thanks, Deng Brett Porter wrote: > Hi Deng, > > On 22/10/2007, at 3:30 AM, oching@apache.org wrote: > >> @@ -89,13 +105,12 @@ >> try >> { >> Configuration configuration = archivaConfiguration.getConfiguration(); >> + cleanupRepositoryData( existingRepository ); >> removeRepository( repoid, configuration ); >> result = saveConfiguration( configuration ); >> >> if ( result.equals( SUCCESS ) ) >> { >> - cleanupRepositoryData( existingRepository ); >> - > > Can you just clarify why this was moved? > >> private void cleanupRepositoryData( ManagedRepositoryConfiguration >> cleanupRepository ) >> - throws RoleManagerException >> + throws RoleManagerException, ArchivaDatabaseException >> { >> removeRepositoryRoles( cleanupRepository ); >> >> // TODO: [MRM-382] Remove index from artifacts of deleted managed >> repositories. >> >> - // TODO: [MRM-265] After removing a managed repository - >> Browse/Search still see it >> - >> + // [MRM-265] After removing a managed repository - Browse/Search >> still see it >> + cleanupDatabase( cleanupRepository.getId() ); >> + cleanupScanStats( cleanupRepository.getId() ); >> + >> // [MRM-520] Proxy Connectors are not deleted with the deletion of a >> Repository. >> List proxyConnectors = >> getProxyConnectors(); >> for ( ProxyConnectorConfiguration proxyConnector : proxyConnectors ) > > Just a general note (not specific to this commit) - we need to start > thinking about the accumulation of logic in the web actions and > shuffle it over to the business layer. > > Thanks! > > Cheers, > Brett > > -- > Brett Porter - brett@apache.org > Blog: http://www.devzuz.org/blogs/bporter/ >