archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r586635 - in /maven/archiva/trunk/archiva-web/archiva-webapp/src: main/java/org/apache/maven/archiva/web/action/admin/repositories/ test/java/org/apache/maven/archiva/web/action/admin/repositories/
Date Sat, 20 Oct 2007 08:41:37 GMT
pass the repo id in as a parameter?

It's not a lot of code, no big deal, it's just that I noticed the  
other was already factored into a method and these classes had  
recently been emphasised as needing to share more code :)

- Brett

On 20/10/2007, at 2:07 PM, Joakim Erdfelt wrote:

> You'd think so, but the rule is different.
> One removes based on connector.sourceId and the other removes based  
> on connector.targetId
> Guess I could bring out the commons-collection's Predicates again  
> to make a common base method. ;-)
>
> - Joakim
>
> Brett Porter wrote:
>>
>> On 20/10/2007, at 8:48 AM, joakime@apache.org wrote:
>>
>>> +        // [MRM-520] Proxy Connectors are not deleted with the  
>>> deletion of a Repository.
>>> +        List<ProxyConnectorConfiguration> proxyConnectors =  
>>> getProxyConnectors();
>>> +        for ( ProxyConnectorConfiguration proxyConnector :  
>>> proxyConnectors )
>>> +        {
>>> +            if ( StringUtils.equals 
>>> ( proxyConnector.getSourceRepoId(), cleanupRepository.getId() ) )
>>> +            {
>>> +                archivaConfiguration.getConfiguration 
>>> ().removeProxyConnector( proxyConnector );
>>> +            }
>>> +        }
>>
>> Shouldn't this duplication be in the common base class?
>>
>> - Brett
>>
>> -- 
>> Brett Porter - brett@apache.org
>> Blog: http://www.devzuz.org/blogs/bporter/
>>
>
>
> -- 
> - Joakim Erdfelt
>  joakim@erdfelt.com
>  Open Source Software (OSS) Developer

--
Brett Porter - brett@apache.org
Blog: http://www.devzuz.org/blogs/bporter/

Mime
View raw message