archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r586919 - in /maven/archiva/trunk: archiva-base/archiva-consumers/archiva-database-consumers/src/main/java/org/apache/maven/archiva/consumers/database/ archiva-database/src/main/java/org/apache/maven/archiva/database/ archiva-database/src/m...
Date Mon, 22 Oct 2007 01:10:25 GMT

On 22/10/2007, at 10:42 AM, Maria Odea Ching wrote:

> Hi Brett,
>
> I thought that if there was a problem cleaning up the repository  
> data, the delete of the repo shouldn't proceed.. or should it? :-)

That makes sense - I just wanted to check if there was anything else.

My only concern is the saveConfiguration method returning something  
other than success and the repository will still be configured but  
most of the data deleted. I'm not sure if that's possible, though :)

Anyway, this should be fine for now - if we do push these back from  
the web layer we should ensure we have some more testing around the  
exception cases.

Thanks,
Brett

>
> Thanks,
> Deng
>
> Brett Porter wrote:
>> Hi Deng,
>>
>> On 22/10/2007, at 3:30 AM, oching@apache.org wrote:
>>
>>> @@ -89,13 +105,12 @@
>>> try
>>> {
>>> Configuration configuration =  
>>> archivaConfiguration.getConfiguration();
>>> + cleanupRepositoryData( existingRepository );
>>> removeRepository( repoid, configuration );
>>> result = saveConfiguration( configuration );
>>>
>>> if ( result.equals( SUCCESS ) )
>>> {
>>> - cleanupRepositoryData( existingRepository );
>>> -
>>
>> Can you just clarify why this was moved?

Mime
View raw message