Return-Path: Delivered-To: apmail-maven-archiva-dev-archive@locus.apache.org Received: (qmail 81281 invoked from network); 14 Aug 2007 12:12:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 14 Aug 2007 12:12:37 -0000 Received: (qmail 25413 invoked by uid 500); 14 Aug 2007 12:12:34 -0000 Delivered-To: apmail-maven-archiva-dev-archive@maven.apache.org Received: (qmail 25382 invoked by uid 500); 14 Aug 2007 12:12:34 -0000 Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: archiva-dev@maven.apache.org Delivered-To: mailing list archiva-dev@maven.apache.org Received: (qmail 25373 invoked by uid 99); 14 Aug 2007 12:12:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Aug 2007 05:12:34 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [210.50.30.235] (HELO mx05.syd.iprimus.net.au) (210.50.30.235) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Aug 2007 12:12:44 +0000 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAACs5wUY6sjg1/2dsb2JhbAAN X-IronPort-AV: E=Sophos;i="4.19,259,1183298400"; d="scan'208";a="60903815" Received: from 53.128.dsl.syd.iprimus.net.au (HELO [192.168.237.213]) ([58.178.56.53]) by smtp05.syd.iprimus.net.au with ESMTP; 14 Aug 2007 22:12:04 +1000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <20070814113405.C61F11A981A@eris.apache.org> References: <20070814113405.C61F11A981A@eris.apache.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <8752DEDD-3058-4D9D-AB71-BFA3FBBB2C1C@apache.org> Content-Transfer-Encoding: 7bit From: Brett Porter Subject: Re: svn commit: r565709 - /maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java Date: Tue, 14 Aug 2007 22:12:00 +1000 To: archiva-dev@maven.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org well spotted! just wondering, should this be in a finally block? (I'm not sure where the IOException actually comes from, and whether it occurs after the searcher is opened or not). - Brett On 14/08/2007, at 9:34 PM, oching@apache.org wrote: > Author: oching > Date: Tue Aug 14 04:34:04 2007 > New Revision: 565709 > > URL: http://svn.apache.org/viewvc?view=rev&rev=565709 > Log: > - MultiSearcher for index is not being closed causing too many > files open error, added line for close searcher > > > Modified: > maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/ > org/apache/maven/archiva/indexer/search/ > DefaultCrossRepositorySearch.java > > Modified: maven/archiva/trunk/archiva-base/archiva-indexer/src/main/ > java/org/apache/maven/archiva/indexer/search/ > DefaultCrossRepositorySearch.java > URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/ > archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/ > search/DefaultCrossRepositorySearch.java? > view=diff&rev=565709&r1=565708&r2=565709 > ====================================================================== > ======== > --- maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/ > org/apache/maven/archiva/indexer/search/ > DefaultCrossRepositorySearch.java (original) > +++ maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/ > org/apache/maven/archiva/indexer/search/ > DefaultCrossRepositorySearch.java Tue Aug 14 04:34:04 2007 > @@ -237,6 +237,8 @@ > } > } > } > + > + searcher.close(); > } > catch ( IOException e ) > { >