Return-Path: Delivered-To: apmail-maven-archiva-dev-archive@locus.apache.org Received: (qmail 90640 invoked from network); 16 Aug 2007 04:31:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 16 Aug 2007 04:31:23 -0000 Received: (qmail 93322 invoked by uid 500); 16 Aug 2007 04:31:20 -0000 Delivered-To: apmail-maven-archiva-dev-archive@maven.apache.org Received: (qmail 93199 invoked by uid 500); 16 Aug 2007 04:31:19 -0000 Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: archiva-dev@maven.apache.org Delivered-To: mailing list archiva-dev@maven.apache.org Delivered-To: moderator for archiva-dev@maven.apache.org Received: (qmail 75305 invoked by uid 99); 15 Aug 2007 07:13:16 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Message-ID: <46C2A774.8060504@devzuz.com> Date: Wed, 15 Aug 2007 15:12:52 +0800 From: Maria Odea Ching User-Agent: Thunderbird 1.5.0.12 (X11/20070604) MIME-Version: 1.0 To: archiva-dev@maven.apache.org Subject: Re: svn commit: r565709 - /maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java References: <20070814113405.C61F11A981A@eris.apache.org> <8752DEDD-3058-4D9D-AB71-BFA3FBBB2C1C@apache.org> In-Reply-To: <8752DEDD-3058-4D9D-AB71-BFA3FBBB2C1C@apache.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org yeah, i think this should be in the finally block. i'll fix this up :) Thanks, Deng Brett Porter wrote: > well spotted! > > just wondering, should this be in a finally block? (I'm not sure where > the IOException actually comes from, and whether it occurs after the > searcher is opened or not). > > - Brett > > On 14/08/2007, at 9:34 PM, oching@apache.org wrote: > >> Author: oching >> Date: Tue Aug 14 04:34:04 2007 >> New Revision: 565709 >> >> URL: http://svn.apache.org/viewvc?view=rev&rev=565709 >> Log: >> - MultiSearcher for index is not being closed causing too many files >> open error, added line for close searcher >> >> >> Modified: >> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java >> >> >> Modified: >> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java >> >> URL: >> http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java?view=diff&rev=565709&r1=565708&r2=565709 >> >> ============================================================================== >> >> --- >> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java >> (original) >> +++ >> maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java >> Tue Aug 14 04:34:04 2007 >> @@ -237,6 +237,8 @@ >> } >> } >> } >> + >> + searcher.close(); >> } >> catch ( IOException e ) >> { >> >