archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r565709 - /maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/search/DefaultCrossRepositorySearch.java
Date Tue, 14 Aug 2007 12:12:00 GMT
well spotted!

just wondering, should this be in a finally block? (I'm not sure  
where the IOException actually comes from, and whether it occurs  
after the searcher is opened or not).

- Brett

On 14/08/2007, at 9:34 PM, oching@apache.org wrote:

> Author: oching
> Date: Tue Aug 14 04:34:04 2007
> New Revision: 565709
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=565709
> Log:
> - MultiSearcher for index is not being closed causing too many  
> files open error, added line for close searcher
>
>
> Modified:
>     maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/ 
> org/apache/maven/archiva/indexer/search/ 
> DefaultCrossRepositorySearch.java
>
> Modified: maven/archiva/trunk/archiva-base/archiva-indexer/src/main/ 
> java/org/apache/maven/archiva/indexer/search/ 
> DefaultCrossRepositorySearch.java
> URL: http://svn.apache.org/viewvc/maven/archiva/trunk/archiva-base/ 
> archiva-indexer/src/main/java/org/apache/maven/archiva/indexer/ 
> search/DefaultCrossRepositorySearch.java? 
> view=diff&rev=565709&r1=565708&r2=565709
> ====================================================================== 
> ========
> --- maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/ 
> org/apache/maven/archiva/indexer/search/ 
> DefaultCrossRepositorySearch.java (original)
> +++ maven/archiva/trunk/archiva-base/archiva-indexer/src/main/java/ 
> org/apache/maven/archiva/indexer/search/ 
> DefaultCrossRepositorySearch.java Tue Aug 14 04:34:04 2007
> @@ -237,6 +237,8 @@
>                      }
>                  }
>              }
> +
> +            searcher.close();
>          }
>          catch ( IOException e )
>          {
>

Mime
View raw message