archiva-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: normalize usage in RepositoryAccess
Date Sat, 09 Dec 2006 02:40:11 GMT
Wouldn't the windows SMB name be //central/etc/password? ie,  
normalize should remove duplicate path separators unless they are  
leading?

- Brett

On 09/12/2006, at 8:17 AM, Henri Yandell wrote:

> In looking at moving from Plexus FileUtils.normalize to IO
> FilenameUtils.normalize, there's on feature difference in that the
> latter does not convert '//etc/passwd' to '/etc/passwd'. Kenney
> suggests on #plexus that that is probably to support Windows SMB
> names.
>
> RepositoryAccessTest contains a test that now fails:
>
>        assertRequestPath( "central", "/etc/passwd", "/central//etc/ 
> passwd" );
>
> It returns '//etc/passwd'.
>
> Anyone know if the solution here is:
>
> a) To consider /etc/passwd the right answer.
> or
> b) To modify the getRepositoryPath method to fold '^//' into '/'.
>
> Or something else?
>
> Hen

Mime
View raw message