Return-Path: Delivered-To: apmail-maven-archiva-dev-archive@locus.apache.org Received: (qmail 22955 invoked from network); 6 Nov 2006 02:48:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Nov 2006 02:48:40 -0000 Received: (qmail 64770 invoked by uid 500); 6 Nov 2006 02:48:51 -0000 Delivered-To: apmail-maven-archiva-dev-archive@maven.apache.org Received: (qmail 64700 invoked by uid 500); 6 Nov 2006 02:48:51 -0000 Mailing-List: contact archiva-dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: archiva-dev@maven.apache.org Delivered-To: mailing list archiva-dev@maven.apache.org Received: (qmail 64691 invoked by uid 99); 6 Nov 2006 02:48:51 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Nov 2006 18:48:51 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [203.59.1.199] (HELO mail-ihug.icp-qv1-irony5.iinet.net.au) (203.59.1.199) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Nov 2006 18:48:37 -0800 Received: from 203-158-38-82.dyn.iinet.net.au (HELO [192.168.237.86]) ([203.158.38.82]) by mail-ihug.icp-qv1-irony5.iinet.net.au with ESMTP; 06 Nov 2006 10:48:09 +0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAFAwTkXLniZSdGdsb2JhbAANjDwB X-IronPort-AV: i="4.09,389,1157299200"; d="scan'208"; a="992978950:sNHT5240011892" Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <263DF505-6575-4494-8B4A-E90EB1AD6845@maven.org> References: <20061105024314.6B0201A9846@eris.apache.org> <263DF505-6575-4494-8B4A-E90EB1AD6845@maven.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Brett Porter Subject: Re: svn commit: r471342 - /maven/archiva/trunk/archiva-converter/src/main/java/org/apache/maven/archiva/converter/DefaultRepositoryConverter.java Date: Mon, 6 Nov 2006 13:48:06 +1100 To: archiva-dev@maven.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org On 06/11/2006, at 12:49 PM, Jason van Zyl wrote: > > On 6 Nov 06, at 5:57 AM 6 Nov 06, Brett Porter wrote: > >> I'm not convinced about this. This is basically ignoring checksums >> in the source repository - shouldn't we be forcing them to correct >> them? I'd like to do the same thing on sync. >> > > It's logged and we can point people at the report to correct them. > Otherwise the whole conversion stops dead and not. I'll take not > stopping dead and providing a warning. What we should do with the > warning should be improved so that people who are syncing know what > to correct. Yeah, stopping dead is bad - so does this report and not sync them, or does it report and autocorrect them? I'm leaning towards the first - report the problem, sync everything else, but skip the ones with bad source checksums. - Brett