apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c
Date Tue, 02 Jul 2019 14:40:23 GMT
On Tue, Jul 02, 2019 at 08:22:47AM -0500, Greg Stein wrote:
> On Tue, Jul 2, 2019 at 8:04 AM Branko ─îibej <brane@apache.org> wrote:
> > Perhaps this is the right time to note (again) that over in Subversion
> > land, we found that functions should take _two_ pool parameters: one for
> > allocating the returned values and one for temporary allocations. This
> > is better than functions creating temporary subpools for temporaries,
> > because it allows the API consumer better control over allocations.
> https://subversion.apache.org/docs/community-guide/conventions.html#apr-pools

No argument from me, applying this guidance consistently to the APR API 
would be a massive improvement - and also a massive BC break!

APR is particularly bad about embedding pool pointers in public 
structures - sockaddr is a big PITA here.

View raw message