apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r1862071 - in /apr/apr/trunk: file_io/os2/dir.c file_io/unix/dir.c file_io/win32/dir.c include/apr_file_info.h test/testdir.c
Date Tue, 02 Jul 2019 12:04:16 GMT
On Tue, Jul 02, 2019 at 11:18:31AM +0100, Joe Orton wrote:
> Reading the win32 code a bit more, it is not constant-memory even with 
> the buffer in apr_dir_t, because it can allocate from dir->pool (and 
> even create cleanups!) in the more_finfo() call, so I think the current 
> behaviour is not justifiable.

Also, since the Unix implementation calls apr_stat(), which takes a 
pool, I actually can't imagine there is another way around the need for 
a pool passed to apr_dir_read() call to guarantee constant memory.

View raw message