Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: AC_CHECK_LIB issues under maintainer mode (Was: Re: Tagging
 2.4.29 / 2.5.0-{alpha/beta?} today)
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: <f7edda28-0c6e-bb88-6a61-8473a023bf21@kippdata.de>
Date: Mon, 16 Oct 2017 04:23:29 -0400
Cc: dev@httpd.apache.org,
 List List <dev@apr.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <8097FDD3-C0E2-40E3-B365-DE58DA996538@jaguNET.com>
References: <CACsi253tht5fJO3Vtr33OzsjHHeMdg-FPvgO6nQBNyLJON0w2g@mail.gmail.com>
 <52D25D9D-347F-4C79-800A-8CC0372BE005@greenbytes.de>
 <CACsi252JZVdc7Oj2O2F7pX=XcAp8R940VuXFkkX0xPiqjeJ3bQ@mail.gmail.com>
 <44e40cdf-0d21-a25b-5a45-6521777c3be3@thelounge.net>
 <84262985-E153-48B3-8F81-C1B52384B6FD@jaguNET.com>
 <6aed9d66-a477-d3a8-d6b5-5893fc0830e9@kippdata.de>
 <CAKQ1sVPzfNtCsSAx5CCJw_C6swE_Gtb7cMZyGEz9pUV7dsmuUg@mail.gmail.com>
 <f7edda28-0c6e-bb88-6a61-8473a023bf21@kippdata.de>
To: Rainer Jung <rainer.jung@kippdata.de>
archived-at: Mon, 16 Oct 2017 08:25:43 -0000

I'd be +1 on setting -Wno-error=3Dstrict-prototypes unconditionally

> On Oct 15, 2017, at 11:52 AM, Rainer Jung <rainer.jung@kippdata.de> =
wrote:
>=20
> Am 15.10.2017 um 16:25 schrieb Yann Ylavic:
>> On Sun, Oct 15, 2017 at 4:03 PM, Rainer Jung =
<rainer.jung@kippdata.de> wrote:
>>>=20
>>> Why is this happening now? The "-Werror" was backported last =
December in
>>> r1772330, which was a backport of r1702948 from trunk (May 2015). =
Maybe
>>> people haven't used maintainer mode since then?
>> During the backport process of r1772330, Jacob noticed that -Werror
>> was not working as expected (see STATUS changes in this commit). He
>> also made a comment on dev@ here:
>> https://marc.info/?l=3Dapache-cvs&m=3D147508169616462&w=3D2
>> Maybe -Werror is just ignored somehow, because I always compile in
>> maintainer mode with several gcc versions...
>=20
> Thanks Yann, I actually only ran gcc with the respective flags. But =
indeed configure checks for each flag whether it is "working" and the =
program which gets compiled is:
>=20
> int
> main ()
> {
> struct tm tm; tm.tm_gmtoff;
>  ;
>  return 0;
> }
>=20
> So since we set -Wstrict-prototypes before, -Werror turns this into
>=20
> conftest.c:45:1: error: function declaration isn't a prototype =
[-Werror=3Dstrict-prototypes]
> main ()
> ^~~~
>=20
> and -Werror does not get set at all.
>=20
> Nevertheless I would still say that adding =
"-Wno-error=3Dstrict-prototypes" for any clang and gcc version that =
supports it would be the correct option. Then -Werror should =
automatically get applied again.
>=20
> So something like the following (simple) patch should be an =
improvement for gcc and clang and also fix Jim's problem. Of course =
since we then would have -Werror enabled probably for the first time for =
gcc other new problems might show (that will currently only be =
observable as warnings during maintainer builds).
>=20
> Index: configure.in
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- configure.in        (revision 1812218)
> +++ configure.in        (working copy)
> @@ -597,6 +597,7 @@
>     if test "$GCC" =3D "yes"; then
>       APR_ADDTO(CFLAGS,[-Wall -Wmissing-prototypes -Wstrict-prototypes =
-Wmissing-declarations -Wpointer-arith])
>       APACHE_ADD_GCC_CFLAG([-std=3Dc89])
> +      APACHE_ADD_GCC_CFLAG([-Wno-error=3Dstrict-prototypes])
>       APACHE_ADD_GCC_CFLAG([-Werror])
>       APACHE_ADD_GCC_CFLAG([-Wdeclaration-after-statement])
>       APACHE_ADD_GCC_CFLAG([-Wformat])
>=20
> Regards,
>=20
> Rainer