Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
From: "Bert Huijben" <bert@qqmail.nl>
To: <dev@apr.apache.org>,
	<commits@apr.apache.org>
References: <20170829145914.D66163A00A3@svn01-us-west.apache.org>
In-Reply-To: <20170829145914.D66163A00A3@svn01-us-west.apache.org>
Subject: RE: svn commit: r1806603 - /apr/apr/trunk/file_io/win32/readwrite.c
Date: Wed, 30 Aug 2017 12:28:00 +0200
Message-ID: <008801d3217a$a857cf10$f9076d30$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: nl
Thread-Index: AQKJeXfF8AKP5qKR5qn1Wet5WevhOKEwAhZA
archived-at: Wed, 30 Aug 2017 10:28:09 -0000


> -----Original Message-----
> From: ivan@apache.org [mailto:ivan@apache.org]
> Sent: dinsdag 29 augustus 2017 16:59
> To: commits@apr.apache.org
> Subject: svn commit: r1806603 - =
/apr/apr/trunk/file_io/win32/readwrite.c
>=20
> Author: ivan
> Date: Tue Aug 29 14:59:11 2017
> New Revision: 1806603
>=20
> URL: http://svn.apache.org/viewvc?rev=3D1806603&view=3Drev
> Log:
> Minor refactoring of the Win32 file write code.
>=20
> * file_io/win32/readwrite.c
>   (apr_file_write): Update filePtr in the asynchronous I/O mode after
>    the WriteFile() call.  This allows simplifying the condition by not
>    checking for thefile->pipe property.
>=20
> Patch by: Evgeny Kotkov <evgeny.kotkov {at} visualsvn.com>
>=20
> Modified:
>     apr/apr/trunk/file_io/win32/readwrite.c
>=20
> Modified: apr/apr/trunk/file_io/win32/readwrite.c
> URL:
> =
http://svn.apache.org/viewvc/apr/apr/trunk/file_io/win32/readwrite.c?rev
> =3D1806603&r1=3D1806602&r2=3D1806603&view=3Ddiff
> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- apr/apr/trunk/file_io/win32/readwrite.c (original)
> +++ apr/apr/trunk/file_io/win32/readwrite.c Tue Aug 29 14:59:11 2017
> @@ -398,6 +398,9 @@ APR_DECLARE(apr_status_t) apr_file_write
>              }
>              rv =3D WriteFile(thefile->filehand, buf, (DWORD)*nbytes, =
&bwrote,
>                             thefile->pOverlapped);
> +            if (rv =3D=3D APR_SUCCESS && thefile->pOverlapped) {
> +                thefile->filePtr +=3D *nbytes;
> +            }

The result of WriteFile should not be checked against APR_SUCCESS, as =
that is not a documented Windows result code. The right constant =
evaluating to 0 should be used.

	Bert