apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William A Rowe Jr <wr...@rowe-clan.net>
Subject Re: [VOTE] Release APR-1.6.1 and APR-UTIL 1.6.0
Date Wed, 31 May 2017 19:25:52 GMT
On Wed, May 31, 2017 at 2:15 PM, William A Rowe Jr <wrowe@rowe-clan.net> wrote:
> Investigating which commit may have been missed... Update within the hour.
> On May 31, 2017 1:44 PM, "Gregg Smith" <gls@gknw.net> wrote:
>> Something tells me not everything of timelock got ripped out.
>>         cl.exe /nologo /MD /W3 /Zi /O2 /Oy- /I "./include" /I
>> "./include/arch" /I "./include/arch/wi
>> n32" /I "./include/arch/unix" /D "NDEBUG" /D "APR_DECLARE_STATIC" /D
>> "WIN32" /D "WINNT" /D "_WINDOWS
>> " /Fo".\LibR\\" /Fd".\LibR\apr-1" /FD /c .\locks\win32\proc_mutex.c
>> proc_mutex.c
>> .\locks\win32\proc_mutex.c(46): error C2065: 'APR_LOCK_DEFAULT_TIMED':
>> undeclared identifier

As often happens in mixed-purpose overloaded commits, this one needs to be
backed out in pieces with a number of them retained;

r1738806 | ylavic | 2016-04-12 09:16:40 -0500 (Tue, 12 Apr 2016) | 26 lines

Merge r1733775, r1738791 from trunk:

apr_proc/global_mutex: Fix API regarding the native OS mutexes
accessors from/to available APR mechanisms, adding the new functions
apr_os_proc_mutex_get_ex() and apr_os_proc_mutex_set_ex() which give
control to the user over the selected mechanisms, including the missing
POSIX semaphores (sem_t) on platforms supporting them.

For POSIX sems, this moves the "sem_t *psem_interproc;" member from struct
apr_proc_mutex_t to apr_os_proc_mutex_t (now complete) so that we can avoid
members duplication between the two structs, and hence replace all the doublons
in apr_os_proc_mutex_t with an apr_os_proc_mutex_t member, called "os", to be
used for runtime.

This first commit aims to be backportable to 1.6.x, thus does not address the
Netware case which requires an incompatible change of the apr_proc_mutex_t to
a pointer type (the implementation is here since very similar to other changes
is this commit, but it is commented out for now, a simple follow up is coming
with the type change for trunk only...).

proc_mutex-unix: follow up to r1733775.
Restore mmap-ed fd close stripped by above commit.

View raw message