Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r1790105 - in /apr/apr/branches/1.6.x:
 locks/unix/misc.c locks/unix/proc_mutex.c locks/unix/thread_mutex.c
 test/testlock.c
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: <CAKQ1sVN8dtvvWmOdf_iahqbc25M+AtVO3Y9YJ9OEqbWhzp0MtA@mail.gmail.com>
Date: Thu, 6 Apr 2017 15:43:46 -0400
Cc: apr-dev <dev@apr.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <9582C16C-FD42-4024-9D8C-913F71EEED85@jaguNET.com>
References: <20170404130903.8844D3A05CD@svn01-us-west.apache.org>
 <CAKQ1sVOTnfCDF0tLELLU2u0KWeVsqumNGZWzZ1JM7+EK=FvdJw@mail.gmail.com>
 <9DB5F466-AAE0-42A1-ADE9-A96AD48A1C58@jaguNET.com>
 <CAKQ1sVN9dVwznB3N0pUBiZvC2cK3JF5fFHOw-yhdqvjS_pthTA@mail.gmail.com>
 <30603077-6dea-9f59-9b47-17d99d4e3451@apache.org>
 <CAKQ1sVPqmEXHAePgUUeEedFc5NZaP_5zFK0PowDFg0_-Zsad_w@mail.gmail.com>
 <62931933-0659-ac8d-9b60-d2161607e07a@apache.org>
 <CAKQ1sVP915nLp0aQmLYncptG9xhgtCoh-EgAu+g99RDTHyd0Yg@mail.gmail.com>
 <4b9e1343-2925-ac09-9dfd-a02b2ef85fc7@apache.org>
 <56e1d3ea-76c9-614a-4c41-7a3656e3abe1@apache.org>
 <CAKQ1sVOzv=xchemv8YMhkn6B9NCFmOuafKLrVwTH+Kf8S73c6A@mail.gmail.com>
 <FA7B3C76-C2FB-497A-8461-D292E832D259@jaguNET.com>
 <CAKQ1sVN8dtvvWmOdf_iahqbc25M+AtVO3Y9YJ9OEqbWhzp0MtA@mail.gmail.com>
To: Yann Ylavic <ylavic.dev@gmail.com>
archived-at: Thu, 06 Apr 2017 19:46:11 -0000

As of HEAD on apr-trunk, all tests pass fine on OSX.
Plus:
  ./include/arch/unix/apr_private.h:#define =
HAVE_PTHREAD_CONDATTR_SETPSHARED 1

So I'm +1 for backporting to 1.6!

> On Apr 6, 2017, at 2:49 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>=20
> On Thu, Apr 6, 2017 at 1:40 PM, Jim Jagielski <jim@jagunet.com> wrote:
>> apr-trunk (r1790379):
>>  % ./testall -v testprocmutex
>>  testprocmutex       : -Line 189: Locks don't appear to work with =
timedlock
>>  -flock_timedlock() not implemented,/Line 189: Locks don't appear to =
work with timedlock
>>  -Line 189: Locks don't appear to work with timedlock
>>  -fcntl_timedlock() not implemented,-Line 133: create the mutex
>>  /default_timed_timedlock() not implemented,-Line 172: Default timed =
timedlock not implemented
>>  FAILED 4 of 6
>>  Failed Tests                  Total   Fail    Failed %
>>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>>  testprocmutex                     6      4     66.67%
>>=20
>> apr-1.6 (r1790305):
>>  % ./testall -v testprocmutex
>>  testprocmutex       : -flock_timedlock() not implemented,-Line 194: =
Locks don't appear to work with timedlock
>>  -fcntl_timedlock() not implemented,FAILED 1 of 6
>>  Failed Tests                  Total   Fail    Failed %
>>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
>>  testprocmutex                     6      1     16.67%
>>=20
>> we seem to be going backwards (apr-trunk includes the fallback)
>> since now we lost default_timed_timedlock()
>=20
> I tried to not modify the other (non PROC_PTHREAD) mechanisms =
normally.
> Could it be, e.g., r1790303 (which is not in 1.6.x either)?
>=20
> Anyway, I just commited another fallback (r1790436), could you please
> test this version on OSX?
> If pshared mutex+cond still do not work as expected on OSX, maybe we
> could un-configure it (i.e. ac_have_pthread_condattr_setpshared=3D"no")
> and let it fall through the new generic fallback...