apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@apache.org>
Subject Re: svn commit: r1790105 - in /apr/apr/branches/1.6.x: locks/unix/misc.c locks/unix/proc_mutex.c locks/unix/thread_mutex.c test/testlock.c
Date Thu, 06 Apr 2017 19:01:19 GMT
On 06.04.2017 20:49, Yann Ylavic wrote:
> On Thu, Apr 6, 2017 at 1:40 PM, Jim Jagielski <jim@jagunet.com> wrote:
>> apr-trunk (r1790379):
>>   % ./testall -v testprocmutex
>>   testprocmutex       : -Line 189: Locks don't appear to work with timedlock
>>   -flock_timedlock() not implemented,/Line 189: Locks don't appear to work with timedlock
>>   -Line 189: Locks don't appear to work with timedlock
>>   -fcntl_timedlock() not implemented,-Line 133: create the mutex
>>   /default_timed_timedlock() not implemented,-Line 172: Default timed timedlock not
implemented
>>   FAILED 4 of 6
>>   Failed Tests                  Total   Fail    Failed %
>>   ===================================================
>>   testprocmutex                     6      4     66.67%
>>
>> apr-1.6 (r1790305):
>>   % ./testall -v testprocmutex
>>   testprocmutex       : -flock_timedlock() not implemented,-Line 194: Locks don't
appear to work with timedlock
>>   -fcntl_timedlock() not implemented,FAILED 1 of 6
>>   Failed Tests                  Total   Fail    Failed %
>>   ===================================================
>>   testprocmutex                     6      1     16.67%
>>
>> we seem to be going backwards (apr-trunk includes the fallback)
>> since now we lost default_timed_timedlock()
> I tried to not modify the other (non PROC_PTHREAD) mechanisms normally.
> Could it be, e.g., r1790303 (which is not in 1.6.x either)?
>
> Anyway, I just commited another fallback (r1790436), could you please
> test this version on OSX?
> If pshared mutex+cond still do not work as expected on OSX, maybe we
> could un-configure it (i.e. ac_have_pthread_condattr_setpshared="no")
> and let it fall through the new generic fallback...

This is on OSX 10.11.6 with clang from XCode 8.2.1.


trunk:

$ ./testall -v testprocmutex
testprocmutex       : SUCCESS
/Error 61 occurred attempting to reach memcached on localhost:11211.  Skipping apr_memcache
tests...
/Error 61 occurred attempting to reach Redis on localhost:6379.  Skipping apr_redis tests...
All tests passed.


1.6.x:

$ ./testall -v testprocmutex
testprocmutex       : -flock_timedlock() not implemented,-Line 194: Locks don't appear to
work with timedlock
-fcntl_timedlock() not implemented,FAILED 1 of 6
Failed Tests   		Total	Fail	Failed %
===================================================
testprocmutex  		    6	   1	 16.67%



FWIW both trunk and branch have a new warning on OSX in maintaner mode:

.../atomic/unix/builtins.c:71:53: warning: passing 'const void *' to parameter of type 'volatile
void *' discards
      qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
    return (void*) __sync_val_compare_and_swap(mem, cmp, with);
                                                    ^~~


-- Brane

Mime
View raw message