Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CAKQ1sVNbyh-2jW5fZSM02tP+zNCbGwA2V+M1stmnQk1KO-q5Xg@mail.gmail.com>
References: <A6DD9031-7199-4181-A186-CF9BD581AD2D@jaguNET.com>
 <88266bdb-ff23-f9f4-fd3e-e4750c64fe08@kippdata.de> <E60FA5C3-136E-47AC-96A1-64199F0ED1CB@jaguNET.com>
 <CACsi250UphNsE+0HnG5jMcy7M5-yLAhh9+Ly3VdFr=bj1hKL_Q@mail.gmail.com>
 <22F9DA06-06D8-4E40-BF9C-0FEB33906440@jaguNET.com> <CACsi2514ow7t8Fp86JmE6DnN9V6ZEkv4Z82jWogNJrYJN4-kZw@mail.gmail.com>
 <BF846758-7107-4FB5-A14C-97C64D244C82@jaguNET.com> <CACsi252B5nnxWSCzmR8PTEYM4tYHi1w9L-9-pvn=_kcvc70Wog@mail.gmail.com>
 <CAKQ1sVOBC37JhHPCQnQPzhhSpPtfufp+Bth+0Op02r1cxH1hVw@mail.gmail.com> <CAKQ1sVNbyh-2jW5fZSM02tP+zNCbGwA2V+M1stmnQk1KO-q5Xg@mail.gmail.com>
From: Yann Ylavic <ylavic.dev@gmail.com>
Date: Wed, 11 Jan 2017 22:26:07 +0100
Message-ID: <CAKQ1sVM2vze8hq04=6H0esjxNnPom8ygOt-XMM75QaDO=tGOOA@mail.gmail.com>
Subject: Re: testpoll
To: APR Developer List <dev@apr.apache.org>
Content-Type: text/plain; charset=UTF-8
archived-at: Wed, 11 Jan 2017 21:26:25 -0000

On Wed, Jan 11, 2017 at 10:20 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Wed, Jan 11, 2017 at 10:17 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>> On Wed, Jan 11, 2017 at 10:05 PM, William A Rowe Jr <wrowe@rowe-clan.net> wrote:
>>> On Wed, Jan 11, 2017 at 2:51 PM, Jim Jagielski <jim@jagunet.com> wrote:
>>>> It looks like it is taking time for the message to
>>>> arrive and that is what is causing the APR_EINTR. After
>>>> all, it is behaving exacting like a wait for no data.
>>>> The apr_sleep() "ensures" time.
>>>
>>> But isn't -1 'infinite' wait, by definition?
>>
>> I think Jim's patch is about the message sent not reaching the read
>> size of the socket before poll() is call, hence the wakeup applies.
>
> Sorry, if your parser failed, s/size/side/ and s/call/called/ ;)

For test fairness (i.e. when both data and wakeup are available, data
win), I think the sleep should come after the wakeup, otherwise the
test might pass because the wakeup is not there yet (though less
likely to happen with pipe than with a socket).