apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William A Rowe Jr <wr...@rowe-clan.net>
Subject Re: [PATCH] Optimize apr_file_info_get(APR_FINFO_SIZE) on Windows
Date Sat, 17 Dec 2016 18:47:02 GMT
APR is C-T-R. If it is larger or significant change/addition, discussion on
list first is great, but most of APR has been JDI.

As 1.6 is unreleased, whatever goes in trunk that does -not- break
backwards binary compat can go right into 1.6 as well.

So go for it, don't worry about STATUS unless the proposal is under
debate/discussion.

On Dec 17, 2016 10:23 AM, "Ivan Zhakov" <ivan@visualsvn.com> wrote:

> On 17 December 2016 at 10:56, William A Rowe Jr <wrowe@rowe-clan.net>
> wrote:
> > On Sat, Dec 17, 2016 at 1:43 AM, Ivan Zhakov <ivan@visualsvn.com> wrote:
> >>
> >> On 24 August 2016 at 20:34, Ivan Zhakov <ivan@visualsvn.com> wrote:
> >> > I was monitoring Subversion server I/O on Windows and noticed that
> >> > apr_file_info_get(APR_FINFO_SIZE) involves two syscalls
> >> > (QueryInformationVolume and QueryAllInformationFile). The
> >> > apr_file_info_get(APR_FINFO_SIZE) is actively used by Subversion
> >> > filesystem and optimizing it gives around 5-10% IO reduction.
> >> >
> >> > Attached patch adds optimized codepath to apr_file_info_get() when
> >> > only APR_FINFO_SIZE is requested.
> >> >
> >> Committed in r1774712.
> >
> >
> > Suggest you might want to backport to the 1.6.x soon-to-be branch.
> Thanks. Should I just backport it to 1.6.x branch or it should be
> nominated to branches/1.6.x/STATUS?
>
>
> --
> Ivan Zhakov
>

Mime
View raw message