apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From olli hauer <oha...@gmx.de>
Subject Possible issue in apr/file_io/unix/filestat.c with clank35+ and optimization level above -O0
Date Tue, 18 Nov 2014 21:06:27 GMT
A user found a possible issue in apr-1.5.1/file_io/unix/filestat.c. [1]

It seems the following code snippet will could be an potential issue in
case apr is build with clang35 and optimization level is above -O0


--- apr-1.5.1/file_io/unix/filestat.c
+++ apr-1.5.1/file_io/unix/filestat.c
@@ -297,7 +297,6 @@ APR_DECLARE(apr_status_t) apr_stat(apr_f
         finfo->pool = pool;
         finfo->fname = fname;
         fill_out_finfo(finfo, &info, wanted);
-        if (wanted & APR_FINFO_LINK)
             wanted &= ~APR_FINFO_LINK;
         return (wanted & ~finfo->valid) ? APR_INCOMPLETE : APR_SUCCESS;
     }

Can someone from the APR team verify the findings ?


[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193905


-- 
Regards,
olli

Mime
View raw message