apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject fix a technicality with struct sockaddr_un in 1.6.x branch???
Date Thu, 19 Jun 2014 18:15:48 GMT
Index: include/apr_network_io.h
===================================================================
--- include/apr_network_io.h (revision 1603975)
+++ include/apr_network_io.h (working copy)
@@ -267,13 +267,17 @@
 #endif
 #if APR_HAVE_SA_STORAGE
         /** Placeholder to ensure that the size of this union is not
-         * dependent on whether APR_HAVE_IPV6 is defined. */
+         * dependent on whether APR_HAVE_IPV6 or APR_HAVE_SOCKADDR_UN
+         * is defined. */
         struct sockaddr_storage sas;
-#endif
 #if APR_HAVE_SOCKADDR_UN
-        /** Unix domain socket sockaddr structure */
+        /** Unix domain socket sockaddr structure; note that adding
+         * this when sockaddr_storage isn't available breaks
+         * binary compatibility
+         */
         struct sockaddr_un unx;
 #endif
+#endif
     } sa;
 };

But maybe Yann is working on a more useful revision that allows APR apps to
take advantage of longer AF_UNIX paths?  I dunno.

-- 
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/

Mime
View raw message