Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
Subject: Re: apr_skiplist (current) implementation wrt mpm_event (timers,
 keepalives?)
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: 
 <CAKQ1sVMPPfTOxanUML09oC9NLucAcQk0jsKj+zAajKk2KpiMeA@mail.gmail.com>
Date: Tue, 27 May 2014 11:12:54 -0400
Cc: apr <dev@apr.apache.org>
Content-Transfer-Encoding: 7bit
Message-Id: <EBFDB5CB-BBB9-4CC2-9BF7-2F2C5FB7B6D1@jaguNET.com>
References: 
 <CAKQ1sVN1MvgjcNjyBuOp-hXXN2JVwbVxr1jUQgpdGEKDZQFpKg@mail.gmail.com>
 <2294416A-D0CE-4DC4-9950-E3CD41B1840B@jaguNET.com>
 <1988EA1D-808C-486A-BE16-4C46B0613044@jaguNET.com>
 <CAKQ1sVMPPfTOxanUML09oC9NLucAcQk0jsKj+zAajKk2KpiMeA@mail.gmail.com>
To: Yann Ylavic <ylavic.dev@gmail.com>

But that would change behavior, which we really shouldn't
do.

On May 27, 2014, at 11:01 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> On Tue, May 27, 2014 at 4:21 PM, Jim Jagielski <jim@jagunet.com> wrote:
>> Check out r1597797
>> 
>> If OK, we can backport to 1.6
> 
> I would have preferred skiplist_insert() == skiplist_add(), since it
> seems to be needed by mpm_event (unless we require APR 1.6 for
> httpd-2.4.x).
> But I guess it's a (behaviour) change which is not acceptable in APR.
> Is there any other apr_skiplist user other than httpd though?
> 
> Otherwise I find the "replace" name a bit misleading, the previous
> value seems to be preserved instead (the new one being ignored).
> However the replace implementation looks non trivial, it would require
> to replace the duplicated (stacked) entries as well (void *data =>
> void **data?)...
>