apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Fritsch ...@sfritsch.de>
Subject Re: svn commit: r1593614 - in /apr/apr/trunk: CHANGES configure.in memory/unix/apr_pools.c
Date Sat, 17 May 2014 22:16:24 GMT
On Thursday 15 May 2014 10:03:25, Ruediger Pluem wrote:
> > +    if (old == 2 && pool->in_use_by == apr_os_thread_current()) {
> 
> How can old ever be 2?

That was a leftover from a version with a separate state for the pool 
being cleared.

> 
> > +        /* cleanups may use the pool */
> > +        return;
> > +    }
> > +
> > +    if (old != 0)
> > +        pool_concurrency_abort(pool, __func__, old);
> 
> Isn't __func__ C99?


Thanks for the review. Both issues fixed in r1595549.

Stefan

Mime
View raw message