apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian J. France" <br...@brianfrance.com>
Subject Re: apr_socket_opt_set always sets TCP_DEFER_ACCEPT to 1
Date Wed, 30 Apr 2014 13:12:27 GMT

On Apr 30, 2014, at 5:59 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> On Tue, Apr 29, 2014 at 5:41 PM, Jim Jagielski <jim@jagunet.com> wrote:
>> 
>> On Apr 22, 2014, at 9:43 AM, Brian J. France <brian@brianfrance.com> wrote:
>>> 
>>> Doh, this is my bad:  on != one
>>> 
>>> http://svn.apache.org/viewvc/apr/apr/trunk/network_io/unix/sockopt.c?view=markup#l113
>>> 
>>> For some reason I completely missed that.  APR is fine, but httpd needs updated
as it is hard coded to 1:
>>> 
>>> rv = apr_socket_opt_set(s, APR_TCP_DEFER_ACCEPT, 1);
>>> 
>>> Will move to the httpd list.
>> 
>> 
>> Did I miss this on dev@httpd?


No, you didn't miss it.  Got tied up with other stuff at work and didn't get back to it.

Was also looking at what it would take patch httpd before posting.



> I seems that httpd trunk and 2.4.x use "apr_socket_opt_set(s,
> APR_TCP_DEFER_ACCEPT, 30);" whereas 2.2.x uses a value of 1.


This is kinda good news.

Brian
Mime
View raw message