apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: make_tools_dir target in Makefile.in
Date Thu, 24 Apr 2014 19:08:37 GMT
On Tue, Apr 22, 2014 at 5:15 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> Hello,
>
> the target make_tools_dir (.PHONY) causes gen_test_char to be always
> rebuilt whenever make is called.
>
> I came up with the following patch :
>
> Index: Makefile.in
> ===================================================================
> --- Makefile.in    (revision 1589047)
> +++ Makefile.in    (working copy)
> @@ -53,7 +53,7 @@
>
>  CLEAN_TARGETS = apr-config.out apr.exp exports.c export_vars.c .make.dirs
> \
>      build/apr_rules.out tools/gen_test_char@EXEEXT@ \
> -    tools/gen_test_char.o tools/gen_test_char.lo \
> +    tools/gen_test_char.o tools/gen_test_char.lo tools/.made \
>      include/private/apr_escape_test_char.h
>  DISTCLEAN_TARGETS = config.cache config.log config.status \
>      include/apr.h include/arch/unix/apr_private.h \
> @@ -161,11 +161,12 @@
>  etags:
>      etags `find . -name '*.[ch]'`
>
> -make_tools_dir:
> +tools/.made:
>      $(APR_MKDIR) tools
> +    touch tools/.made
>
>  OBJECTS_gen_test_char = tools/gen_test_char.lo $(LOCAL_LIBS)
> -tools/gen_test_char.lo: make_tools_dir
> +tools/gen_test_char.lo: tools/.made
>  tools/gen_test_char@EXEEXT@: $(OBJECTS_gen_test_char)
>      $(LINK_PROG) $(OBJECTS_gen_test_char) $(ALL_LIBS)
>
> [END]
>
> Hope this helps.
>
> Regards,
> Yann.
>

That would need the dummy file to be cleaned up (hardly a problem :) )

Here's an alternative...

Index: Makefile.in
===================================================================
--- Makefile.in (revision 1587538)
+++ Makefile.in (working copy)
@@ -161,11 +161,11 @@
 etags:
  etags `find . -name '*.[ch]'`

-make_tools_dir:
+OBJECTS_gen_test_char = tools/gen_test_char.lo $(LOCAL_LIBS)
+tools/gen_test_char.lo: tools/gen_test_char.c
  $(APR_MKDIR) tools
+ $(LT_COMPILE)

-OBJECTS_gen_test_char = tools/gen_test_char.lo $(LOCAL_LIBS)
-tools/gen_test_char.lo: make_tools_dir
 tools/gen_test_char@EXEEXT@: $(OBJECTS_gen_test_char)
  $(LINK_PROG) $(OBJECTS_gen_test_char) $(ALL_LIBS)



-- 
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/

Mime
View raw message