apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: Event and atomics, round II
Date Wed, 08 Jan 2014 13:21:11 GMT


> -----Original Message-----
> From: Jim Jagielski 
> Sent: Mittwoch, 8. Januar 2014 14:03
> To: Jeff Trawick
> Cc: Apache HTTP Server Development List; apr
> Subject: Re: Event and atomics, round II
> 
> 
> On Jan 7, 2014, at 3:15 PM, Jeff Trawick <trawick@gmail.com> wrote:
> >
> > +1 for APR trunk, +0.9 for future APR 1.6.x, -0.9 for APR 1.5.x...
> >
> > alternate opinions?
> >
> 
> As far as I know, C guarantees that
> 
> 	if (a)
> 
> is the same as
> 
> 	if (a != 0)
> 
> So I'm unsure of the need for this patch.

yeah, the question is what it really changes. I guess what needs changing is the expectation
by the caller that the previous value is returned and not just a boolean that indicates that
the *new* value is zero or not (true if not).

Regards

Rüdiger

Mime
View raw message