apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jim Jagielski <...@jaguNET.com>
Subject Re: svn commit: r1561347 - /apr/apr/trunk/shmem/unix/shm.c
Date Sun, 26 Jan 2014 21:37:04 GMT
Yeah, I'm doing testing against that... it most
cases the caller already aligns the data, but it
does seem that apr-shm making sure does make sense,
and, as you see, it would be good to be consistent
with the other impl's. Right now I'm trying to find
a test case where using  new_m->realsize makes a
difference...

On Jan 26, 2014, at 4:06 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> On Sun, Jan 26, 2014 at 9:54 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> @@ -338,7 +322,7 @@ APR_DECLARE(apr_status_t) apr_shm_create(apr_shm_t
>              return status;
>          }
>          /* TODO: should we use new_m->realsize instead of reqsize ?? */
> 
> It seems you already figured out this, I didn't see the comment (another commit)... 
> Sorry for the noise (it should be fixed however IMHO).
> 


Mime
View raw message