Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of bert@qqmail.nl designates
 74.125.82.53 as permitted sender)
From: "Bert Huijben" <bert@qqmail.nl>
To: "'APR Developer List'" <dev@apr.apache.org>
Subject: CMake build doesn't define 'WINNT',
 but apr headers check for it anyway
Date: Thu, 5 Dec 2013 15:13:58 +0100
Message-ID: <008e01cef1c4$3e974c70$bbc5e550$@qqmail.nl>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_NextPart_000_008F_01CEF1CC.A05E2570"
Thread-Index: Ac7xxD1VK89Ue51ZRZ6ih+wQQ9C58w==
Content-Language: nl

This is a multipart message in MIME format.

------=_NextPart_000_008F_01CEF1CC.A05E2570
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit

                Hi,

 
On Windows apr_arch_misc.h checks for the 'WINNT' define, which was
unconditionally defined on Windows before the CMake build. But now it is no
longer defined. This enables some additional dynamic load operations that
could fail in some cases (See "Race condition in APR_DECLARE_LATE_DLL_FUNC()
implementation").

 
We could fix this by defining WINNT, but we might as well just remove the
check as we don't support systems older than NT 4.0 anyway..

 
                Bert


------=_NextPart_000_008F_01CEF1CC.A05E2570
Content-Type: text/html;
	charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

<html xmlns:v=3D"urn:schemas-microsoft-com:vml" =
xmlns:o=3D"urn:schemas-microsoft-com:office:office" =
xmlns:w=3D"urn:schemas-microsoft-com:office:word" =
xmlns:m=3D"http://schemas.microsoft.com/office/2004/12/omml" =
xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta =
http-equiv=3DContent-Type content=3D"text/html; =
charset=3Dus-ascii"><meta name=3DGenerator content=3D"Microsoft Word 15 =
(filtered medium)"><style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:0 0 0 0 0 0 0 0 0 0;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";
	mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal-compose;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri","sans-serif";
	mso-fareast-language:EN-US;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext=3D"edit" spidmax=3D"1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext=3D"edit">
<o:idmap v:ext=3D"edit" data=3D"1" />
</o:shapelayout></xml><![endif]--></head><body lang=3DNL =
link=3D"#0563C1" vlink=3D"#954F72"><div class=3DWordSection1><p =
class=3DMsoNormal>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Hi,<o:p></o:p></p><p =
class=3DMsoNormal><o:p>&nbsp;</o:p></p><p class=3DMsoNormal><span =
lang=3DEN-US>On Windows apr_arch_misc.h checks for the =
&#8216;WINNT&#8217; define, which was unconditionally defined on Windows =
before the CMake build. But now it is no longer defined. This enables =
some additional dynamic load operations that could fail in some cases =
(See &#8220;Race condition in APR_DECLARE_LATE_DLL_FUNC() =
implementation&#8221;).<o:p></o:p></span></p><p class=3DMsoNormal><span =
lang=3DEN-US><o:p>&nbsp;</o:p></span></p><p class=3DMsoNormal><span =
lang=3DEN-US>We could fix this by defining WINNT, but we might as well =
just remove the check as we don&#8217;t support systems older than NT =
4.0 anyway..<o:p></o:p></span></p><p class=3DMsoNormal><span =
lang=3DEN-US><o:p>&nbsp;</o:p></span></p><p class=3DMsoNormal><span =
lang=3DEN-US>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; =
Bert<o:p></o:p></span></p></div></body></html>
------=_NextPart_000_008F_01CEF1CC.A05E2570--