apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: CMake build doesn't define 'WINNT', but apr headers check for it anyway
Date Thu, 05 Dec 2013 14:48:08 GMT
On Thu, Dec 5, 2013 at 9:13 AM, Bert Huijben <bert@qqmail.nl> wrote:

>                 Hi,
>
>
>
> On Windows apr_arch_misc.h checks for the ‘WINNT’ define, which was
> unconditionally defined on Windows before the CMake build. But now it is no
> longer defined. This enables some additional dynamic load operations that
> could fail in some cases (See “Race condition in
> APR_DECLARE_LATE_DLL_FUNC() implementation”).
>
>
>
> We could fix this by defining WINNT, but we might as well just remove the
> check as we don’t support systems older than NT 4.0 anyway..
>
>
>
>                 Bert
>

Thanks!

Visual Studio project file maintainers, can I just remove the /D "WINNT"
everywhere?  I hate to leave that dangling.  (Obviously the C code will be
changed to stop referencing it too :) )

-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Mime
View raw message