apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregg Smith <...@gknw.net>
Subject Re: CMake build doesn't define 'WINNT', but apr headers check for it anyway
Date Thu, 05 Dec 2013 17:24:24 GMT
Grrrr.
On 12/5/2013 9:23 AM, Gregg Smith wrote:
> On 12/5/2013 6:48 AM, Jeff Trawick wrote:
>> On Thu, Dec 5, 2013 at 9:13 AM, Bert Huijben <bert@qqmail.nl 
>> <mailto:bert@qqmail.nl>> wrote:
>>
>> Hi,
>>
>> On Windows apr_arch_misc.h checks for the ‘WINNT’ define, which
>> was unconditionally defined on Windows before the CMake build. But
>> now it is no longer defined. This enables some additional dynamic
>> load operations that could fail in some cases (See “Race condition
>> in APR_DECLARE_LATE_DLL_FUNC() implementation”).
>>
>> We could fix this by defining WINNT, but we might as well just
>> remove the check as we don’t support systems older than NT 4.0
>> anyway..
>>
>> Bert
>>
>>
>> Thanks!
>>
>> Visual Studio project file maintainers, can I just remove the /D 
>> "WINNT" everywhere? I hate to leave that dangling. (Obviously the C 
>> code will be changed to stop referencing it too :) )
>
> There's no reason to support 9x, we just want all the WINNT code. Once 
> all the 9x stuff is gone, we can drop the define.
>


Mime
View raw message