apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: buffered files read after apr_file_close()'ed
Date Mon, 02 Dec 2013 23:37:39 GMT
On Mon, 02 Dec 2013 01:34:58 +0100
Branko ─îibej <brane@apache.org> wrote:

> On 02.12.2013 01:29, Eric Covener wrote:
> > I am looking at a httpd bug that causes a hang on windows but
> > succeeds on unix.
> >
> > It seems that (short) files are opened w/ buffering, read,
> > apr_file_closed, and read again [succesfully on unix]
> >
> > On Unix, they sare satisfied out of the buffer.  file->fileset is
> > -1. On Windows, the destroyed apr_thread_mutex causes a hang.
> >
> > Is reading from the closed file on the extreme bogus end of the
> > spectrum as I suspect and just getting lucky on the unix case?
> 
> I'd certainly call a successful read from a closed file a bug.
> 
> > Should they blow up in 2.0 during a read if they've been closed?
> 
> Dunno ... my gut feeling in cases like this is to just leave it be.
> Developers should have some fun finding heisenbugs, too. :)

If we fix this, it needs to be minimal impact.  Zero'ing out the
buffer on close seems like the lowest cpu impact.

Mime
View raw message