Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 01F6410F74 for ; Thu, 7 Nov 2013 10:25:28 +0000 (UTC) Received: (qmail 56690 invoked by uid 500); 7 Nov 2013 10:25:01 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 56585 invoked by uid 500); 7 Nov 2013 10:24:55 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 56507 invoked by uid 99); 7 Nov 2013 10:24:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 10:24:46 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [209.20.83.52] (HELO gungnir.webthing.com) (209.20.83.52) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Nov 2013 10:24:38 +0000 Received: from [192.168.0.2] (cpc2-newt30-2-0-cust371.newt.cable.virginm.net [77.100.121.116]) by gungnir.webthing.com (Postfix) with ESMTPSA id 4E01B128138 for ; Thu, 7 Nov 2013 10:24:17 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1283) Subject: Re: SHA2 in APR From: Nick Kew In-Reply-To: <20131106235756.2591b73d@hub> Date: Thu, 7 Nov 2013 10:24:15 +0000 Content-Transfer-Encoding: 7bit Message-Id: References: <20131106235756.2591b73d@hub> To: dev List X-Mailer: Apple Mail (2.1283) X-Virus-Checked: Checked by ClamAV on apache.org On 7 Nov 2013, at 05:57, William A. Rowe Jr. wrote: > Otherwise, it seems prudent to get out of > the hashing business and rip out md/sha1 entirely from apr 2. -1 to ripping: that's pulling the rug from under existing apps. At worst, deprecate. The question is about exposing existing sha2 code. For: it's there, and serves someone's need. Against: it would appear to be less than complete, and to need a fair bit of work to look comprehensive. I guess I should take yours as a vote against what I was mulling over: namely inviting Dirkjan to submit a patch and commit if it WorksForMe and noone shouts? > I have no issue with providing a simple hash, these are used for just > about all arbitrary string values where you need to uniquify them into > a predictable byte token. That sounds like existing apr_md5 apps. -- Nick Kew