Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates
 209.85.217.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <009e01cee50f$f8c037e0$ea40a7a0$@qqmail.nl>
References: <009e01cee50f$f8c037e0$ea40a7a0$@qqmail.nl>
Date: Tue, 19 Nov 2013 07:30:10 -0500
Message-ID: 
 <CAKUrXK5RWv7Gpum5oBX1nAgi0e8EXhsOjo+Jd4hJhWSp-1e9uQ@mail.gmail.com>
Subject: Re: Error compiling apr_crypto_openssl using cmake
From: Jeff Trawick <trawick@gmail.com>
Cc: APR Developer List <dev@apr.apache.org>
Content-Type: multipart/alternative; boundary=001a11c3ee6a56e6f204eb86d3ed

--001a11c3ee6a56e6f204eb86d3ed
Content-Type: text/plain; charset=ISO-8859-1

On Tue, Nov 19, 2013 at 5:13 AM, Bert Huijben <bert@qqmail.nl> wrote:

>         Hi,
>
> Continuing my work to switch my build chain to cmake for apr, apr-util and
> httpd I now found the same problem in the optional components of apr-util
> that was just fixed in httpd in r1543149: some defines are not quoted
> correctly to the resource compiler when invoked from Visual Studio project
> files.
>

Thanks!


>
> Can somebody apply the attached patch to apr-util 1.5.x?
>

I actually made the simpler change of removing the extra quotes altogether.
 (Perhaps I had based those rc definitions on earlier code in httpd which
had symbols with blanks?)   This works for me with VS 2010 and nmake
generators.

apr trunk: r1543399
apr-util 1.5.x: r1543401


> [[
> * CMakeLists.txt
>    (DEFINE_WITH_BLANKS): New macro.
>    (apr_crypto_openssl,
>     apr_dbd_odbc,
>     apr_ldap): Use DEFINE_WITH_BLANKS to properly generate Visual Studio
>         2005-2013 project files.
> ]]
>
> DEFINE_WITH_BLANKS was copied from trawick's patch on httpd.
>
> Thanks,
>         Bert
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

--001a11c3ee6a56e6f204eb86d3ed
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Tue, Nov 19, 2013 at 5:13 AM, Bert Huijben <span dir=3D=
"ltr">&lt;<a href=3D"mailto:bert@qqmail.nl" target=3D"_blank">bert@qqmail.n=
l</a>&gt;</span> wrote:<br><div class=3D"gmail_extra"><div class=3D"gmail_q=
uote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l=
eft:1px #ccc solid;padding-left:1ex">
=A0 =A0 =A0 =A0 Hi,<br>
<br>
Continuing my work to switch my build chain to cmake for apr, apr-util and<=
br>
httpd I now found the same problem in the optional components of apr-util<b=
r>
that was just fixed in httpd in r1543149: some defines are not quoted<br>
correctly to the resource compiler when invoked from Visual Studio project<=
br>
files.<br></blockquote><div><br></div><div>Thanks!</div><div>=A0</div><bloc=
kquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #cc=
c solid;padding-left:1ex">
<br>
Can somebody apply the attached patch to apr-util 1.5.x?<br></blockquote><d=
iv><br></div><div>I actually made the simpler change of removing the extra =
quotes altogether. =A0(Perhaps I had based those rc definitions on earlier =
code in httpd which had symbols with blanks?) =A0 This works for me with VS=
 2010 and nmake generators.</div>
<div><br></div><div>apr trunk: r1543399</div><div>apr-util 1.5.x: r1543401<=
/div><div><br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0=
 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
[[<br>
* CMakeLists.txt<br>
=A0 =A0(DEFINE_WITH_BLANKS): New macro.<br>
=A0 =A0(apr_crypto_openssl,<br>
=A0 =A0 apr_dbd_odbc,<br>
=A0 =A0 apr_ldap): Use DEFINE_WITH_BLANKS to properly generate Visual Studi=
o<br>
=A0 =A0 =A0 =A0 2005-2013 project files.<br>
]]<br>
<br>
DEFINE_WITH_BLANKS was copied from trawick&#39;s patch on httpd.<br>
<br>
Thanks,<br>
=A0 =A0 =A0 =A0 Bert<br>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>Born in Rosw=
ell... married an alien...<br><a href=3D"http://emptyhammock.com/" target=
=3D"_blank">http://emptyhammock.com/</a><br>
</div></div>

--001a11c3ee6a56e6f204eb86d3ed--