Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B613810FC6 for ; Wed, 6 Nov 2013 09:34:02 +0000 (UTC) Received: (qmail 53435 invoked by uid 500); 6 Nov 2013 09:33:58 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 53033 invoked by uid 500); 6 Nov 2013 09:33:52 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 53010 invoked by uid 99); 6 Nov 2013 09:33:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 09:33:50 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [209.20.83.52] (HELO gungnir.webthing.com) (209.20.83.52) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2013 09:33:42 +0000 Received: from [192.168.0.2] (cpc2-newt30-2-0-cust371.newt.cable.virginm.net [77.100.121.116]) by gungnir.webthing.com (Postfix) with ESMTPSA id 63C38128138 for ; Wed, 6 Nov 2013 09:33:20 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1283) Subject: Re: SHA2 in APR From: Nick Kew In-Reply-To: Date: Wed, 6 Nov 2013 09:33:19 +0000 Content-Transfer-Encoding: 7bit Message-Id: <920A6185-FE9D-49ED-81AB-F481E432F738@apache.org> References: To: dev List X-Mailer: Apple Mail (2.1283) X-Virus-Checked: Checked by ClamAV on apache.org On 6 Nov 2013, at 07:37, Dirkjan Ochtman wrote: > On Wed, Oct 16, 2013 at 5:57 PM, Dirkjan Ochtman wrote: >> Well, the alternatives are (a) relying on an extra dependency for my >> Apache module, probably NSS or OpenSSL or both, or (b) pulling in a >> semi-random copy of SHA2 from the internet and including that. If APR >> already included a maintained version of SHA2 (and it looks like it >> already does, except it's not exposed to external users), that would >> definitely make things easier for me. > > Ping! Is this essentially of the table? I had a brief look, and concluded it could rapidly lead to a lot of work. An even briefer look just now in response to your ping suggests I was missing your point, and that all you're asking for is that random/unix/sha2.h be exposed in the public API. Is that correct? I would guess this code has never been tested, though there's what looks like a placeholder in testpass.c. Have you run it at all? How well does it work for you if you just copy sha2.h manually to your APR include directory and use it for your module? -- Nick Kew