Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of rainer.jung@kippdata.de
 designates 195.227.30.149 as permitted sender)
Message-ID: <52879A40.4010608@kippdata.de>
Date: Sat, 16 Nov 2013 17:16:00 +0100
From: Rainer Jung <rainer.jung@kippdata.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: dev@apr.apache.org
Subject: Re: [VOTE] Release APR-util 1.5.3
References: 
 <CAKUrXK7svEMfMKzz6aBX7f_AWt57DcytDS9dxaX6LpU+32_TvQ@mail.gmail.com>
In-Reply-To: 
 <CAKUrXK7svEMfMKzz6aBX7f_AWt57DcytDS9dxaX6LpU+32_TvQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit

On 13.11.2013 17:48, Jeff Trawick wrote:
> Tarballs/zipfiles are at http://apr.apache.org/dev/dist/
> 
> Shortcut to CHANGES files:
> 
> http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5
> <http://apr.apache.org/dev/dist/CHANGES-APR-1.5>
> http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5
> <http://apr.apache.org/dev/dist/CHANGES-APR-1.5>.3
> 
> autoconf version: 2.69 (same as apr 1.4.8/1.5.0 and apr-util 1.5.2)
> libtool version: 2.4.2 (same as apr 1.4.8/1.5.0 and apr-util 1.5.2)
> 
> +/-1
> [+1] Release apr-util 1.5.3 as GA
> 
> I'll hold the vote open for 72 hours unless something out of the
> ordinary occurs.

My test results:

No regressions.

Summary
=======

- some libtool m4 files not deleted by buildconf (see below)

- crypto configure for OpenSSL expected to fail at least on Solaris,
   because when linking against the libssl we need
   the additional flags "-ldl -lsocket -lnsl". Currently
   there's no way to fix this apart from hacking configure.
   For Linux I'm not sure, but likely you'll need "-ldl".

- LDADD flags are typically not respected during configure,
  only during the make.

- configure fails for Berkeley DB in non-standard path,
   because it doesn't add an rpath to conftest and then tries
   to run the compiled conftest binary.

- no rpath for ldap, mysql and crypto dso extensions. So no
   way to run the result without LD_LIBRARY_PATH.
   Interesting: the m4 file does add an rpath only for oracle.
   Since there's no platform independent way to add rpath,
   we might want to remove it everywhere (and users would need
   to use the respective LDADD variables).

- no rpath for dependency libs when building without dso support,
   e.g. when the ldap, crypto, mysql, oracle, sqlite etc. extensions
   are all in the big apr util library.

- testall often fails in testcrypto when testing nss passphrase
  (see below).

- Windows Build system:
   - test/testutildll.dsp and test/testutillib.dsp are the only DSP
     files containing "Release9x" and "Debug9x" configuration info.
     IMHO that's obsolete and could be removed.
     Probably also in Makefile.win?

Details
=======

- svn compared with gz, bz2 and zip only expected differences
   except for the following in the directory xml/expat/conftools
   which are not a blocker;
   IMHO we could remove those at the and of buildconf
     libtool.m4
     lt~obsolete.m4
     ltoptions.m4
     ltsugar.m4
     ltversion.m4

- files signed, checksums correct

- built and made check on the following platforms:

   - Solaris 8 and 10 Sparc (gcc 4.1.2 resp. 4.8.2)
   - SuSE Linux Enterprise 10 32 Bit and 10 and 11 64 Bit
   - RedHat Enterprise Linux 6 64 Bit

   - using all combinations of:

     - apr 1.5.0
     - expat builtin / 2.1.0
     - OpenSSL 1.0.1e (plus a few patches)
     - dso disable / enable
     - Berkeley DB 5.3.21
     - sqlite 3.8.0.2
     - mysql 6.0.2 (only Solaris)
     - oracle 11.2.0.2.0 (Solaris 10), resp. 10.2.0.5.0 (Solaris 8)
     - platform nss (Solaris 10 and RHEL 6)

- make check for the successful build ran fine for 71 builds,
  but failed for 25 builds:

   - one failure in testdbm on SLES 11 without DSO,
     *not* reproducible (Failed 1 of 2)
     Though not reproducible exactly the same failure happened
     when testing 1.5.0, 1.5.1 and 1.5.2. Maybe due to increased
     load during the parallel builds and checks on the
     virtualized server. Could be a race condition.

  - 24 failures in testcrypto
     testing crypto for nss gives errors on Solaris 10 and on RHEL
     where I had built crypto with nss and OpenSSL (no nss build
     on the other platforms) and dso disabled.
     For details see my 1.5.1 vote mail.

Regards,

Rainer