apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1541745 - /apr/apr/branches/1.5.x/Makefile.in
Date Wed, 13 Nov 2013 23:56:58 GMT
On 14.11.2013 00:09, Jeff Trawick wrote:
> On Wed, Nov 13, 2013 at 4:51 PM, <rjung@apache.org> wrote:
> 
>> Author: rjung
>> Date: Wed Nov 13 21:51:02 2013
>> New Revision: 1541745
>>
>> URL: http://svn.apache.org/r1541745
>> Log:
>> Support out of tree build for traditional make.
>>
> 
> I guess traditional is any non-GNU make?
> 
> This is a regression.
> 
> I don't mind another T&R tomorrow if people think it is warranted.

By "traditional" I meant non-cmake et al., so it applies to gnu make as
well (which I use on all platforms).

Out of tree won't work for make because the rule to create
include/private/apr_escape_test_char.h would try to write it into the
non existing directory include/private (only exists in source, but not
in new build dir). So an mkdir is needed. Furthermore the
include/private directory in the build dir wasn't in the include path.

Personally I think people doing out of tree builds are a minority and
can cope with a small Makefile patch. Theyshould be OK with it already
being fixed for the next release, so for me it wouldn't be a reason to
vote -1.

Regards,

Rainer

Mime
View raw message