apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: [PATCH] apr escape API, portability issues seen on Windows
Date Wed, 09 Oct 2013 20:25:41 GMT
On 03 Oct 2013, at 1:51 AM, Jeff Trawick <trawick@gmail.com> wrote:

> I dug into the glitches seen on Windows...   \e is a non-portable escape (GNU extension),
and shell escaping treats \n differently on Windows and OS/2, which the testcase didn't account
for.
> 
> I guess the code that used \e doesn't match anything in httpd?

Looking back at the code it originated from ap_escape_logitem() and ap_escape_errorlog_item()
which are almost identical but for additional escape sequences.

If \e is non-portable in C it can be removed, an escape character is unlikely to cause harm.

Regards,
Graham
--


Mime
View raw message