apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: svn commit: r1535157 - /apr/apr/trunk/configure.in
Date Fri, 25 Oct 2013 10:27:55 GMT
On Thu, Oct 24, 2013 at 01:39:09AM +0200, Rainer Jung wrote:
> On 23.10.2013 22:22, jorton@apache.org wrote:
> > --- apr/apr/trunk/configure.in (original)
> > +++ apr/apr/trunk/configure.in Wed Oct 23 20:22:57 2013
> > @@ -681,7 +681,7 @@ case $host in
> >          ;;
> >      *linux*)
> >          os_major=[`uname -r | sed -e 's/\([1-9][0-9]*\)\..*/\1/'`]
> > -        os_minor=[`uname -r | sed -e 's/[1-9][0-9]*\.\([1-9][0-9]*\)\..*/\1/'`]
> > +        os_minor=[`uname -r | sed -e 's/[1-9][0-9]*\.\([0-9]+\)\..*/\1/'`]
> 
> Solaris sed only supports basic regexp, which knows about "*" but not "+".
> 
> So instead of "[0-9]+" it could be "[0-9][0-9]*" or "[0-9]\{1,\}",
> whichever you find less annoying.

Surely we don't have to care about what works with Solaris sed on a 
*linux* host?

Regards, Joe

Mime
View raw message