Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of dirkx@webweaving.org designates
 178.18.23.51 as permitted sender)
Subject: Re: [Patch] Apple CommonCrypto implementation for apr_crypto
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Dirk-Willem van Gulik <dirkx@webweaving.org>
In-Reply-To: <F4B77A05-07F7-4902-8184-8FBE9CAF24DA@sharp.fm>
Date: Wed, 3 Oct 2012 13:46:42 +0100
Cc: APR Development List <dev@apr.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <01583ED7-5FB0-4540-AE0E-89EE8D50826B@webweaving.org>
References: <F4B77A05-07F7-4902-8184-8FBE9CAF24DA@sharp.fm>
To: Graham Leggett <minfrin@sharp.fm>


On 22 Sep 2012, at 15:33, Graham Leggett wrote:

> =
http://developer.apple.com/library/mac/#documentation/security/Conceptual/=
cryptoservices/SecureNetworkCommunicationAPIs/SecureNetworkCommunicationAP=
Is.html
>=20
> The following patch adds a CommonCrypto implementation to the =
apr_crypto abstraction for users of OSX and iOS.

Well done. Passes my somewhat esoteric test cases (well, it did not - =
but mine where broken). This intended to go into the main line ?

Dw.


+    case (APR_KEY_AES_128):
+        key->algorithm =3D kCCAlgorithmAES128;
+        key->keyLen =3D kCCKeySizeAES128;
+        key->blockSize =3D kCCBlockSizeAES128;
+        if (mode =3D=3D APR_MODE_CBC) {
+            key->ivSize =3D kCCBlockSizeAES128;
+        }
+        else {
+            key->options +=3D kCCOptionECBMode;
+            key->ivSize =3D 0;
+        }