Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates
 209.85.220.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <4994179EC7ED6843AAB0A30A1639E7F81DB52956DD@DGEX2V.dg.deltagroup.com>
References: 
 <4994179EC7ED6843AAB0A30A1639E7F81DB5260901@DGEX2V.dg.deltagroup.com>
	<CAKUrXK79aSEpB4Y05Cqb6_UFH8TPXzkx34UEH7xw98u-3Y+H=g@mail.gmail.com>
	<4994179EC7ED6843AAB0A30A1639E7F81DB52956DD@DGEX2V.dg.deltagroup.com>
Date: Thu, 19 Jul 2012 07:02:49 -0400
Message-ID: 
 <CAKUrXK5TCQGaFngf+L=0VrTdZn=DHMhNss6=YVfv74xyDQLJUA@mail.gmail.com>
Subject: Re: Please confirm the freetds bug in apr-util-1.4.1.tar.gz
From: Jeff Trawick <trawick@gmail.com>
To: =?GB2312?B?VFJPWS5MSVUghKK0uoKl?= <TROY.LIU@deltaww.com.cn>
Cc: "dev@apr.apache.org" <dev@apr.apache.org>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 18, 2012 at 8:47 PM, TROY.LIU =84=A2=B4=BA=82=A5 <TROY.LIU@delt=
aww.com.cn> wrote:
> Thank you, I will file bug in  http://issues.apache.org/bugzilla/.

I'm sorry if I wasn't clear enough.

You don't need to file a bug for this issue, as I have already
committed your fix.  If you need to file a bug for some future issue,
use http://issues.apache.org/bugzilla/.

Here is your fix in the apr-util 1.4.x branch:

http://svn.apache.org/viewvc?view=3Drevision&revision=3D1362895

(It is also in trunk and 1.5.x.)

>
> -----Original Message-----
> From: Jeff Trawick [mailto:trawick@gmail.com]
> Sent: Wednesday, July 18, 2012 7:34 PM
> To: TROY.LIU =84=A2=B4=BA=82=A5; dev@apr.apache.org
> Subject: Re: Please confirm the freetds bug in apr-util-1.4.1.tar.gz
>
> On Wed, Jul 18, 2012 at 4:38 AM, TROY.LIU =84=A2=B4=BA=82=A5 <TROY.LIU@de=
ltaww.com.cn> wrote:
>> Dear all,
>>
>>   I found a bug and don=A1=AFt know where to file it. Just send the mail=
 to
>> let you know.
>
> Bugs can be filed at http://issues.apache.org/bugzilla/
>
> But in this case I can confirm the bug and will commit your fix shortly.
>
> Thanks!
>
>>
>> In the apr_dbd_freetds.c +630, function freetds_open:
>>
>>
>>
>> sql =3D apr_palloc (pool, sizeof (apr_dbd_t));  // should be
>> apr_pcalloc, like apr_dbd_pgsql_open.c +1231
>>
>>
>>
>> if calls dbd_freetds_query after freetds_open,  it will fail.
>>
>> static int dbd_freetds_query(apr_dbd_t *sql, int *nrows, const char
>> *query)
>>
>> {
>>
>>     if (sql->trans && sql->trans->errnum) {
>>
>>         return sql->trans->errnum;
>>
>> }
>>
>> =A1=AD
>>
>>
>>
>> Please confirm this issue.
>>
>>
>>
>> http://svn.apache.org/viewvc/apr/apr-util/branches/1.4.x/dbd/apr_dbd_f
>> reetds.c?view=3Dmarkup
>>
>> http://svn.apache.org/viewvc/apr/apr-util/branches/1.5.x/dbd/apr_dbd_f
>> reetds.c?view=3Dmarkup
>>
>>
>>
>>
>>
>>
>>
>> Best Regards
>>
>> Chunwei Liu
>>
>>
>
>
>
> --
> Born in Roswell... married an alien...
> http://emptyhammock.com/


--=20
Born in Roswell... married an alien...
http://emptyhammock.com/