apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TROY.LIU 劉春偉 <TROY....@DELTAWW.COM.CN>
Subject RE: Please confirm the freetds bug in apr-util-1.4.1.tar.gz
Date Thu, 19 Jul 2012 00:47:13 GMT
Thank you, I will file bug in  http://issues.apache.org/bugzilla/.

-----Original Message-----
From: Jeff Trawick [mailto:trawick@gmail.com] 
Sent: Wednesday, July 18, 2012 7:34 PM
To: TROY.LIU 劉春偉; dev@apr.apache.org
Subject: Re: Please confirm the freetds bug in apr-util-1.4.1.tar.gz

On Wed, Jul 18, 2012 at 4:38 AM, TROY.LIU 劉春偉 <TROY.LIU@deltaww.com.cn> wrote:
> Dear all,
>
>   I found a bug and don’t know where to file it. Just send the mail to 
> let you know.

Bugs can be filed at http://issues.apache.org/bugzilla/

But in this case I can confirm the bug and will commit your fix shortly.

Thanks!

>
> In the apr_dbd_freetds.c +630, function freetds_open:
>
>
>
> sql = apr_palloc (pool, sizeof (apr_dbd_t));  // should be  
> apr_pcalloc, like apr_dbd_pgsql_open.c +1231
>
>
>
> if calls dbd_freetds_query after freetds_open,  it will fail.
>
> static int dbd_freetds_query(apr_dbd_t *sql, int *nrows, const char 
> *query)
>
> {
>
>     if (sql->trans && sql->trans->errnum) {
>
>         return sql->trans->errnum;
>
> }
>
> …
>
>
>
> Please confirm this issue.
>
>
>
> http://svn.apache.org/viewvc/apr/apr-util/branches/1.4.x/dbd/apr_dbd_f
> reetds.c?view=markup
>
> http://svn.apache.org/viewvc/apr/apr-util/branches/1.5.x/dbd/apr_dbd_f
> reetds.c?view=markup
>
>
>
>
>
>
>
> Best Regards
>
> Chunwei Liu
>
>



--
Born in Roswell... married an alien...
http://emptyhammock.com/

Mime
View raw message