Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D03F9256 for ; Mon, 2 Apr 2012 11:49:28 +0000 (UTC) Received: (qmail 91555 invoked by uid 500); 2 Apr 2012 11:49:27 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 91397 invoked by uid 500); 2 Apr 2012 11:49:27 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 91388 invoked by uid 99); 2 Apr 2012 11:49:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Apr 2012 11:49:27 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of minfrin@sharp.fm designates 72.32.122.20 as permitted sender) Received: from [72.32.122.20] (HELO chandler.sharp.fm) (72.32.122.20) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Apr 2012 11:49:17 +0000 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id 25162A48015; Mon, 2 Apr 2012 06:48:56 -0500 (CDT) Received: from [10.0.0.251] (87-194-125-19.bethere.co.uk [87.194.125.19]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: minfrin@sharp.fm) by chandler.sharp.fm (Postfix) with ESMTP id AE7E7A48013; Mon, 2 Apr 2012 06:48:54 -0500 (CDT) Subject: Re: svn commit: r1308135 - in /apr/apr-util/branches/1.4.x: ./ CHANGES crypto/apr_crypto.c Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: multipart/signed; boundary=Apple-Mail-634-725331634; protocol="application/pkcs7-signature"; micalg=sha1 From: Graham Leggett In-Reply-To: Date: Mon, 2 Apr 2012 13:48:53 +0200 Cc: Jeff Trawick , dev@apr.apache.org Message-Id: References: To: Greg Stein X-Mailer: Apple Mail (2.1084) X-Virus-Scanned: ClamAV using ClamSMTP --Apple-Mail-634-725331634 Content-Type: multipart/alternative; boundary=Apple-Mail-633-725331547 --Apple-Mail-633-725331547 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 02 Apr 2012, at 2:35 AM, Greg Stein wrote: > My point is that svn:mergeinfo is not a replacement for proper branch = management and helpful log messages. >=20 We're not talking about proper branch management and helpful log = messages, both of which are a given. Instead we're talking about = duplicating the revision recorded within svn:mergeinfo inside the log = message. I was under the impression this duplication wasn't necessary, = and that someone needing to know the revision number could simply look = it up. I agree that the duplication does make people's lives easier, so = am happy to do it. > > > > Personally, I'm am utterly exhausted by constantly being told by = this person and then that person that some or other completely = undocumented pattern isn't being followed. All I want to do is fix some = bugs, get a release out the door, and help some long suffering Windows = folks who are having problems with static builds. >=20 > Oh, cry me a river. Proper branch management produces repeatable, = solid releases for this users. >=20 > You're "exhausted" by two commit reviews?! Seriously? >=20 No Greg, I am exhausted by constantly being told by this person and then = that person that some or other completely undocumented pattern isn't = being followed. I thought I made that clear. This project has come to an agreement in the past over how CHANGES files = are to be handled. If you disagree with the way this project has decided = to handle CHANGES files, then start a new thread and reboot that = discussion. Do not sweep in and accuse me of making reckless backports = because I followed the APR project's way of backporting instead of = subversion's way of backporting. To be most specific: = http://subversion.apache.org/docs/community-guide/releasing.html#the-chang= es-file "Remember that CHANGES should always be edited on trunk and then merged = over to the release branch(es) when necessary. It is very important that = all changes of all releases be documented in the CHANGES file on trunk, = both for future reference and so that future release branches contain = the sum of all previous change logs." While I agree with the above, the rest of the APR project does not. Regards, Graham -- --Apple-Mail-633-725331547 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

My point is that svn:mergeinfo = is not a replacement for proper branch management and helpful log = messages.

We're not talking about proper branch = management and helpful log messages, both of which are a given. Instead = we're talking about duplicating the revision recorded within = svn:mergeinfo inside the log message. I was under the impression this = duplication wasn't necessary, and that someone needing to know the = revision number could simply look it up. I agree that the duplication = does make people's lives easier, so am happy to do it.

>
> Personally, I'm am utterly exhausted by constantly being told by = this person and then that person that some or other completely = undocumented pattern isn't being followed. All I want to do is fix some = bugs, get a release out the door, and help some long suffering Windows = folks who are having problems with static builds.

Oh, cry me a = river. Proper branch management produces repeatable, solid releases for = this users.

You're "exhausted" by two commit reviews?! = Seriously?

No Greg, I am exhausted by constantly = being told by this person and then that person that some or other = completely undocumented pattern isn't being followed. I thought I made = that clear.

This project has come to an = agreement in the past over how CHANGES files are to be handled. If you = disagree with the way this project has decided to handle CHANGES files, = then start a new thread and reboot that discussion. Do not sweep in and = accuse me of making reckless backports because I followed the APR = project's way of backporting instead of subversion's way of = backporting.

To be most = specific:


"Remember that = CHANGES should always be edited on trunk and then merged over to the release branch(es) when necessary. It is very important that all changes of all releases be documented in the CHANGES file on trunk, both for future reference and so = that future release branches contain the sum of all previous change logs."

While I agree with the above, the rest = of the APR project does = not.

Regards,
Graham
--
=

= --Apple-Mail-633-725331547-- --Apple-Mail-634-725331634 Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIMRDCCBU4w ggQ2oAMCAQICEDYACLHMooL/bsDcM9tdBVowDQYJKoZIhvcNAQEFBQAwgd0xCzAJBgNVBAYTAlVT MRcwFQYDVQQKEw5WZXJpU2lnbiwgSW5jLjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29y azE7MDkGA1UECxMyVGVybXMgb2YgdXNlIGF0IGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9ycGEg KGMpMDkxHjAcBgNVBAsTFVBlcnNvbmEgTm90IFZhbGlkYXRlZDE3MDUGA1UEAxMuVmVyaVNpZ24g Q2xhc3MgMSBJbmRpdmlkdWFsIFN1YnNjcmliZXIgQ0EgLSBHMzAeFw0xMTA1MzAwMDAwMDBaFw0x MjA1MjkyMzU5NTlaMIIBETEXMBUGA1UEChMOVmVyaVNpZ24sIEluYy4xHzAdBgNVBAsTFlZlcmlT aWduIFRydXN0IE5ldHdvcmsxRjBEBgNVBAsTPXd3dy52ZXJpc2lnbi5jb20vcmVwb3NpdG9yeS9S UEEgSW5jb3JwLiBieSBSZWYuLExJQUIuTFREKGMpOTgxHjAcBgNVBAsTFVBlcnNvbmEgTm90IFZh bGlkYXRlZDEzMDEGA1UECxMqRGlnaXRhbCBJRCBDbGFzcyAxIC0gTmV0c2NhcGUgRnVsbCBTZXJ2 aWNlMRcwFQYDVQQDFA5HcmFoYW0gTGVnZ2V0dDEfMB0GCSqGSIb3DQEJARYQbWluZnJpbkBzaGFy cC5mbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAJ4dd4Ds+3IXxDGy1yZqvJjdNjuv lc1lIh5jlWwjFsZQ66wsESHR5Ks4S6RPVizIG1+Ej6xXdXf0XMlI8/QakNrmb8bdPCPtGC2pVYt7 OxFKYQ6m85kedZta56vm4A6qEkzGA5FE+4Gnud2v9PslJqBfwqK37/hRAmuD/UskEiD4UkZ+yH0v PeLZyz5lLpOKkLgCGOwufM5beR5Ns9oSkQxFgQ8uRv7SrU0tMW5cbD4MsKA83ZptrphOWVUBwaWx sEJGNbzXmdKsYTBDLuprQUoNg7D2av9Z58B4ffg2QxOOryWTqwEuKALiHEEXTGxhOjMEsRfrLAJH 4v/psBNHhj8CAwEAAaOB0jCBzzAJBgNVHRMEAjAAMEQGA1UdIAQ9MDswOQYLYIZIAYb4RQEHFwEw KjAoBggrBgEFBQcCARYcaHR0cHM6Ly93d3cudmVyaXNpZ24uY29tL3JwYTALBgNVHQ8EBAMCBaAw HQYDVR0lBBYwFAYIKwYBBQUHAwQGCCsGAQUFBwMCMFAGA1UdHwRJMEcwRaBDoEGGP2h0dHA6Ly9p bmRjMWRpZ2l0YWxpZC1nMy1jcmwudmVyaXNpZ24uY29tL0luZEMxRGlnaXRhbElELUczLmNybDAN BgkqhkiG9w0BAQUFAAOCAQEAEu63vTe3dCGssc80skA94KCZsrJlkWRjtqdmnngNfih6yCP+GvzH SgiPPQYqzlS27T9PdHSpaSMoceVcrEsd8CUJNztubZ6LbTWc/yXzwGZmR03TNgdsD/wGEmTliqEv Z1fqq1hduAwEZYgSZ+huc/P7qh0o7bTsD9v2fqwj6nPXGPDUhPwVNUMcNcPRvvlmtotJWT9P0SKb Eo/XEaa9KnTekZTOLeXbcJZSE75BMRlfSaLC5QQGv2PzIqmmdKB3gCgMHkwlzIXau2fuO9G/BrAR +Q/xjpEMGCEuISO5nLKVq4e6Pjj+Z74fi2T3DxMzNCB5dRSHRDoTBeTsoKZGDjCCBu4wggXWoAMC AQICEHEVZgVK5JEhTem8RPms09wwDQYJKoZIhvcNAQEFBQAwgcoxCzAJBgNVBAYTAlVTMRcwFQYD VQQKEw5WZXJpU2lnbiwgSW5jLjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE6MDgG A1UECxMxKGMpIDE5OTkgVmVyaVNpZ24sIEluYy4gLSBGb3IgYXV0aG9yaXplZCB1c2Ugb25seTFF MEMGA1UEAxM8VmVyaVNpZ24gQ2xhc3MgMSBQdWJsaWMgUHJpbWFyeSBDZXJ0aWZpY2F0aW9uIEF1 dGhvcml0eSAtIEczMB4XDTA5MDUwMTAwMDAwMFoXDTE5MDQzMDIzNTk1OVowgd0xCzAJBgNVBAYT AlVTMRcwFQYDVQQKEw5WZXJpU2lnbiwgSW5jLjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0 d29yazE7MDkGA1UECxMyVGVybXMgb2YgdXNlIGF0IGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9y cGEgKGMpMDkxHjAcBgNVBAsTFVBlcnNvbmEgTm90IFZhbGlkYXRlZDE3MDUGA1UEAxMuVmVyaVNp Z24gQ2xhc3MgMSBJbmRpdmlkdWFsIFN1YnNjcmliZXIgQ0EgLSBHMzCCASIwDQYJKoZIhvcNAQEB BQADggEPADCCAQoCggEBAO3ER98qKB18Bmu71yEyyWwTj+mxjUFONPfaC+Nq+mWIIAsRE+mb4ElO i2/VAdBfDUeRilpMdD4/xpEJu0w0no1uoYJRYvdpdliWB6+eFBgHT1q9n9IxslQZc0ZqGUIR7BJz IY313DDN5dlWCjHFNm0pFJe9LdqJRxmI2EsEPeu2PGcedAATDdCG2pNn+DMDrho8a2l49sAsjuGD P3f5mf/+n1JawrSHCthsqUfBVCllQz5KwJYfwa33d69ssQRevsG2lC2XkC0n0rse6YNqhPbEsq4j BmUmpSdYKwcitG+mYkgad/LVUCeaKdOW+yj1uiR2YuOMWev7btVCxL5Bx/UCAwEAAaOCArkwggK1 MDQGCCsGAQUFBwEBBCgwJjAkBggrBgEFBQcwAYYYaHR0cDovL29jc3AudmVyaXNpZ24uY29tMBIG A1UdEwEB/wQIMAYBAf8CAQAwcAYDVR0gBGkwZzBlBgtghkgBhvhFAQcXATBWMCgGCCsGAQUFBwIB FhxodHRwczovL3d3dy52ZXJpc2lnbi5jb20vY3BzMCoGCCsGAQUFBwICMB4aHGh0dHBzOi8vd3d3 LnZlcmlzaWduLmNvbS9ycGEwNAYDVR0fBC0wKzApoCegJYYjaHR0cDovL2NybC52ZXJpc2lnbi5j b20vcGNhMS1nMy5jcmwwDgYDVR0PAQH/BAQDAgEGMG4GCCsGAQUFBwEMBGIwYKFeoFwwWjBYMFYW CWltYWdlL2dpZjAhMB8wBwYFKw4DAhoEFEtruSiWBgy70FI4mymsSweLIQUYMCYWJGh0dHA6Ly9s b2dvLnZlcmlzaWduLmNvbS92c2xvZ28xLmdpZjAuBgNVHREEJzAlpCMwITEfMB0GA1UEAxMWUHJp dmF0ZUxhYmVsNC0yMDQ4LTExODAdBgNVHQ4EFgQUeUdhCEH9OASiS+e1zPVD9kkrEfgwgfEGA1Ud IwSB6TCB5qGB0KSBzTCByjELMAkGA1UEBhMCVVMxFzAVBgNVBAoTDlZlcmlTaWduLCBJbmMuMR8w HQYDVQQLExZWZXJpU2lnbiBUcnVzdCBOZXR3b3JrMTowOAYDVQQLEzEoYykgMTk5OSBWZXJpU2ln biwgSW5jLiAtIEZvciBhdXRob3JpemVkIHVzZSBvbmx5MUUwQwYDVQQDEzxWZXJpU2lnbiBDbGFz cyAxIFB1YmxpYyBQcmltYXJ5IENlcnRpZmljYXRpb24gQXV0aG9yaXR5IC0gRzOCEQCLW3VWhFSF CwDPrzhIzrGkMA0GCSqGSIb3DQEBBQUAA4IBAQA5Tc9BmYG1qQW1UjjpOYSJbOQ0qFrn2GwJTCQa ulmkhztzIfGTgc+/aGNaZ/41hSuhw12jSsI6Gd0w1sxN7/HSgZfKVFpDvzeLeo4ZjQ9DqIzyr2Cz FYqzlZw84J6zJ5ikNXIX5fwqXYfTig3C0UUq+MD0rCqTOtWuEnAI6/s74nfs6CtkNXbNutrg0csU 1nFYm77VPn222egkxSRmTF2RH3azFz5/DcYhiS+zN7ih/1yybUneZVJC+w6I0u1KHb9L4/jMcvpI DmWOScjW+JmYO7eUPjFxBof6bFlTLtffK+1fYwCsFe0DuFUWjMZoA+ciqHMLsbyg2lJY3QoOf8GC MYIEizCCBIcCAQEwgfIwgd0xCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5WZXJpU2lnbiwgSW5jLjEf MB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE7MDkGA1UECxMyVGVybXMgb2YgdXNlIGF0 IGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9ycGEgKGMpMDkxHjAcBgNVBAsTFVBlcnNvbmEgTm90 IFZhbGlkYXRlZDE3MDUGA1UEAxMuVmVyaVNpZ24gQ2xhc3MgMSBJbmRpdmlkdWFsIFN1YnNjcmli ZXIgQ0EgLSBHMwIQNgAIscyigv9uwNwz210FWjAJBgUrDgMCGgUAoIICbTAYBgkqhkiG9w0BCQMx CwYJKoZIhvcNAQcBMBwGCSqGSIb3DQEJBTEPFw0xMjA0MDIxMTQ4NTNaMCMGCSqGSIb3DQEJBDEW BBRTU1ogU4bTOZZVWtDqWelN4GLpWzCCAQMGCSsGAQQBgjcQBDGB9TCB8jCB3TELMAkGA1UEBhMC VVMxFzAVBgNVBAoTDlZlcmlTaWduLCBJbmMuMR8wHQYDVQQLExZWZXJpU2lnbiBUcnVzdCBOZXR3 b3JrMTswOQYDVQQLEzJUZXJtcyBvZiB1c2UgYXQgaHR0cHM6Ly93d3cudmVyaXNpZ24uY29tL3Jw YSAoYykwOTEeMBwGA1UECxMVUGVyc29uYSBOb3QgVmFsaWRhdGVkMTcwNQYDVQQDEy5WZXJpU2ln biBDbGFzcyAxIEluZGl2aWR1YWwgU3Vic2NyaWJlciBDQSAtIEczAhA2AAixzKKC/27A3DPbXQVa MIIBBQYLKoZIhvcNAQkQAgsxgfWggfIwgd0xCzAJBgNVBAYTAlVTMRcwFQYDVQQKEw5WZXJpU2ln biwgSW5jLjEfMB0GA1UECxMWVmVyaVNpZ24gVHJ1c3QgTmV0d29yazE7MDkGA1UECxMyVGVybXMg b2YgdXNlIGF0IGh0dHBzOi8vd3d3LnZlcmlzaWduLmNvbS9ycGEgKGMpMDkxHjAcBgNVBAsTFVBl cnNvbmEgTm90IFZhbGlkYXRlZDE3MDUGA1UEAxMuVmVyaVNpZ24gQ2xhc3MgMSBJbmRpdmlkdWFs IFN1YnNjcmliZXIgQ0EgLSBHMwIQNgAIscyigv9uwNwz210FWjANBgkqhkiG9w0BAQEFAASCAQBf 7eiFhT83wKxX22X2wOwJqamo4C/kgnigwSlXfTymXRoNwlGw04ctPt1g0A9G2HdMlwU2hLxDBXUm irfF7+HAVD/Yyld5p0zI36Q5Ob8vRDw+nEQld6/dLW883AHfKjXdXpT4dXqu1Pr4up8KJMlTY+J5 nUARFrTcrtuvK+c39NCBe8grJot5Se4r2wXaFYdCv0U5R1KoHtch70UnxLZ2CJ5fhAlISC9NDNK4 JhThp8XhxdFpO8NWQFdxuWrzIWyqz/SXyBKEeOE0J6B7YLkP7K1AmTO4LN7dTTvpuETq37R//IJZ jq9H0e7Ge+Tj86z7oaI8Ypjym7gFsgNoIP+8AAAAAAAA --Apple-Mail-634-725331634--