Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4F7CBD4D.80606@rowe-clan.net>
Date: Wed, 04 Apr 2012 16:29:49 -0500
From: "William A. Rowe Jr." <wrowe@rowe-clan.net>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:11.0) Gecko/20120327 Thunderbird/11.0.1
MIME-Version: 1.0
To: dev@apr.apache.org
Subject: Re: svn commit: r1308910 - in /apr/apr/trunk: configure.in
 include/apr_poll.h
 include/arch/unix/apr_arch_poll_private.h poll/unix/pollset.c
 poll/unix/z_asio.c
References: <20120403134807.6A7B723888EA@eris.apache.org>
 <014501cd129d$eca47a20$c5ed6e60$@qqmail.nl>
In-Reply-To: <014501cd129d$eca47a20$c5ed6e60$@qqmail.nl>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 4/4/2012 3:02 PM, Bert Huijben wrote:
> 
> 
>> -----Original Message-----
>> From: gregames@apache.org [mailto:gregames@apache.org]
>> Sent: dinsdag 3 april 2012 6:48
>> To: commits@apr.apache.org
>> Subject: svn commit: r1308910 - in /apr/apr/trunk: configure.in
>> include/apr_poll.h include/arch/unix/apr_arch_poll_private.h
>> poll/unix/pollset.c poll/unix/z_asio.c
>>
>> Author: gregames
>> Date: Tue Apr  3 13:48:06 2012
>> New Revision: 1308910
>>
>> URL: http://svn.apache.org/viewvc?rev=1308910&view=rev
>> Log:
>> support for thread-hopping apr_pollset_* using z/OS async i/o.
>> no support for apr_pollcb yet.
>>
>> Added:
>>     apr/apr/trunk/poll/unix/z_asio.c
>> Modified:
>>     apr/apr/trunk/configure.in
>>     apr/apr/trunk/include/apr_poll.h
>>     apr/apr/trunk/include/arch/unix/apr_arch_poll_private.h
>>     apr/apr/trunk/poll/unix/pollset.c
>>
>> Modified: apr/apr/trunk/configure.in
>> URL:
>> http://svn.apache.org/viewvc/apr/apr/trunk/configure.in?rev=1308910&r1=
>> 1308909&r2=1308910&view=diff
>> ==========================================================
>> ====================
>> --- apr/apr/trunk/configure.in (original)
>> +++ apr/apr/trunk/configure.in Tue Apr  3 13:48:06 2012
>> @@ -1271,6 +1271,7 @@ dnl ----------------------------- Checks
>>  AC_HEADER_STDC
>>
>>  APR_FLAG_HEADERS(
>> +    aio.h               \
>>      ByteOrder.h		\
>>      conio.h		\
>>      crypt.h		\
>> @@ -1368,6 +1369,7 @@ else
>>     netinet_tcph=0
>>  fi
>>
>> +AC_SUBST(aioh)
>>  AC_SUBST(arpa_ineth)
>>  AC_SUBST(conioh)
>>  AC_SUBST(ctypeh)
>>
>> Modified: apr/apr/trunk/include/apr_poll.h
>> URL:
>> http://svn.apache.org/viewvc/apr/apr/trunk/include/apr_poll.h?rev=130891
>> 0&r1=1308909&r2=1308910&view=diff
>> ==========================================================
>> ====================
>> --- apr/apr/trunk/include/apr_poll.h (original)
>> +++ apr/apr/trunk/include/apr_poll.h Tue Apr  3 13:48:06 2012
>> @@ -77,6 +77,7 @@ typedef enum {
>>      APR_POLLSET_KQUEUE,         /**< Poll uses kqueue method */
>>      APR_POLLSET_PORT,           /**< Poll uses Solaris event port method */
>>      APR_POLLSET_EPOLL,          /**< Poll uses epoll method */
>> +    APR_POLLSET_ASIO,           /**< Poll uses z/OS async i/o method */
>>      APR_POLLSET_POLL            /**< Poll uses poll method */
>>  } apr_pollset_method_e;
> 
> As apr_poll.h is a public header, shouldn't new enum values be added at the end to avoid breaking current users?

Trunk is immune, 2.0 will be binary incompatible by design.

But if this were backported, yes, APR_POLLSET_POLL value must not change
during the 1.x lifespan.