From dev-return-24758-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Mar 1 12:20:22 2012 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 98CAA9A06 for ; Thu, 1 Mar 2012 12:20:22 +0000 (UTC) Received: (qmail 37446 invoked by uid 500); 1 Mar 2012 12:20:22 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 37392 invoked by uid 500); 1 Mar 2012 12:20:22 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 37384 invoked by uid 99); 1 Mar 2012 12:20:22 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2012 12:20:22 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 209.85.220.178 as permitted sender) Received: from [209.85.220.178] (HELO mail-vx0-f178.google.com) (209.85.220.178) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2012 12:20:16 +0000 Received: by vcbfo1 with SMTP id fo1so556207vcb.37 for ; Thu, 01 Mar 2012 04:19:55 -0800 (PST) Received-SPF: pass (google.com: domain of trawick@gmail.com designates 10.52.23.199 as permitted sender) client-ip=10.52.23.199; Authentication-Results: mr.google.com; spf=pass (google.com: domain of trawick@gmail.com designates 10.52.23.199 as permitted sender) smtp.mail=trawick@gmail.com; dkim=pass header.i=trawick@gmail.com Received: from mr.google.com ([10.52.23.199]) by 10.52.23.199 with SMTP id o7mr7311046vdf.79.1330604395876 (num_hops = 1); Thu, 01 Mar 2012 04:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=xPWkjhL39++ux7pKDgSENp//vkK8M0mdhXBEfS6CaqY=; b=aEhOxs1yDM8Xgx4loIeM9fYM/Rjw8YccqtyeUoC9wL6hrywiEWlyIIUOEZQj1hnB9f 8Ztsqnsu4Ea3n6R1qCRhasgVNwgM/m2KZRe41Mq5zunm2bd9XdZgzkhGp3qW7IfWeysv 6FILHjvlZWh21nI/k6ounWFapRfK/oII6GjFU= MIME-Version: 1.0 Received: by 10.52.23.199 with SMTP id o7mr6127276vdf.79.1330604395543; Thu, 01 Mar 2012 04:19:55 -0800 (PST) Received: by 10.220.192.69 with HTTP; Thu, 1 Mar 2012 04:19:55 -0800 (PST) In-Reply-To: References: <48D41001658740B68185833D254F8414@Father> Date: Thu, 1 Mar 2012 07:19:55 -0500 Message-ID: Subject: Re: Still #ifdef WIN64 in APR From: Jeff Trawick To: dev@apr.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Mar 1, 2012 at 7:04 AM, Eric Covener wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=49155 says: > > APR_SIZEOF_VOIDP isn't defined as 8 because of the "#ifdef WIN64" statement > preceding "#define APR_SIZEOF_VOIDP 8" in the apr.hw file. It is supposed be > "#ifdef _WIN64". There is another "#ifdef WIN64" in apr.hw which should also be > changed to "#ifdef _WIN64". See also http://stackoverflow.com/a/1648031 So the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=40758 was bad? We also have this reference to "WIN64": ./libapr.rc:#if defined(WINNT) || defined(WIN64) If the post I found is correct, any such checks will work only because the project has defined the symbol. However, I don't see WIN64 getting defined so I don't know why it is checked. (And we seem to define WINNT for 64-bit builds.) Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the .c/.h code. I'll commit that. I guess the attribution to use is the e-mail address in bug 49155. > ---------- Forwarded message ---------- > From: Steffen > Date: Thu, Mar 1, 2012 at 6:15 AM > Subject: Still #ifdef WIN64 in APR > To: dev@httpd.apache.org > > > In APR 1.4.6 there is still a typo in the statements, causes crashes > HTTPD in eg. setting on logging in mod_rewrite. > > In shm.c and apr.hw > > #ifdef WIN64 > > Sould be: > > #ifdef _WIN64 > > > > Steffen > > > -- > Eric Covener > covener@gmail.com -- Born in Roswell... married an alien...