From dev-return-24761-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Mar 1 13:23:35 2012 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D3B309C98 for ; Thu, 1 Mar 2012 13:23:35 +0000 (UTC) Received: (qmail 40169 invoked by uid 500); 1 Mar 2012 13:23:35 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 40088 invoked by uid 500); 1 Mar 2012 13:23:35 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 40077 invoked by uid 99); 1 Mar 2012 13:23:35 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2012 13:23:35 +0000 Received: from localhost (HELO fc16x86v0.jboss.hr) (127.0.0.1) (smtp-auth username mturk, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2012 13:23:35 +0000 Message-ID: <4F4F7853.1040505@apache.org> Date: Thu, 01 Mar 2012 14:23:31 +0100 From: Mladen Turk User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: Still #ifdef WIN64 in APR References: <48D41001658740B68185833D254F8414@Father> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 03/01/2012 01:19 PM, Jeff Trawick wrote: > > Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the > .c/.h code. I'll commit that. I guess the attribution to use is the > e-mail address in bug 49155. > _WIN64 is defined by cl.exe (same as WIN32/_WIN32) WIN64 should be defined by make files, but agreed that's just needless duplication. In case mingw64 doesn't defines _WIN64, this should be added to configure. Regards -- ^TM