apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: Still #ifdef WIN64 in APR
Date Thu, 01 Mar 2012 12:19:55 GMT
On Thu, Mar 1, 2012 at 7:04 AM, Eric Covener <covener@gmail.com> wrote:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=49155 says:
>
> APR_SIZEOF_VOIDP isn't defined as 8 because of the "#ifdef WIN64" statement
> preceding "#define APR_SIZEOF_VOIDP 8" in the apr.hw file. It is supposed be
> "#ifdef _WIN64". There is another "#ifdef WIN64" in apr.hw which should also be
> changed to "#ifdef _WIN64".

See also http://stackoverflow.com/a/1648031

So the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=40758 was bad?

We also have this reference to "WIN64":

./libapr.rc:#if defined(WINNT) || defined(WIN64)

If the post I found is correct, any such checks will work only because
the project has defined the symbol.  However, I don't see WIN64
getting defined so I don't know why it is checked.  (And we seem to
define WINNT for 64-bit builds.)

Regardless of the APR_SIZEOF_VOIDP issue, it should be _WIN64 in the
.c/.h code.  I'll commit that.  I guess the attribution to use is the
e-mail address in bug 49155.


> ---------- Forwarded message ----------
> From: Steffen <info@apachelounge.com>
> Date: Thu, Mar 1, 2012 at 6:15 AM
> Subject: Still #ifdef WIN64 in APR
> To: dev@httpd.apache.org
>
>
> In APR 1.4.6 there is still a typo in the statements, causes crashes
> HTTPD in eg. setting on logging in mod_rewrite.
>
> In shm.c and apr.hw
>
> #ifdef WIN64
>
> Sould be:
>
> #ifdef _WIN64
>
>
>
> Steffen
>
>
> --
> Eric Covener
> covener@gmail.com



-- 
Born in Roswell... married an alien...

Mime
View raw message