From dev-return-24752-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Mon Feb 27 14:14:27 2012 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 202CA95E8 for ; Mon, 27 Feb 2012 14:14:27 +0000 (UTC) Received: (qmail 95611 invoked by uid 500); 27 Feb 2012 14:14:26 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 95477 invoked by uid 500); 27 Feb 2012 14:14:26 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 95463 invoked by uid 99); 27 Feb 2012 14:14:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Feb 2012 14:14:26 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.215.50] (HELO mail-lpp01m010-f50.google.com) (209.85.215.50) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Feb 2012 14:14:21 +0000 Received: by lahm13 with SMTP id m13so5574432lah.37 for ; Mon, 27 Feb 2012 06:13:59 -0800 (PST) Received-SPF: pass (google.com: domain of mat.booth@wandisco.com designates 10.152.135.104 as permitted sender) client-ip=10.152.135.104; Authentication-Results: mr.google.com; spf=pass (google.com: domain of mat.booth@wandisco.com designates 10.152.135.104 as permitted sender) smtp.mail=mat.booth@wandisco.com Received: from mr.google.com ([10.152.135.104]) by 10.152.135.104 with SMTP id pr8mr11236021lab.27.1330352039384 (num_hops = 1); Mon, 27 Feb 2012 06:13:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.152.135.104 with SMTP id pr8mr9448038lab.27.1330352039297; Mon, 27 Feb 2012 06:13:59 -0800 (PST) Received: by 10.152.29.76 with HTTP; Mon, 27 Feb 2012 06:13:59 -0800 (PST) Date: Mon, 27 Feb 2012 14:13:59 +0000 Message-ID: Subject: Makefile.win install target does not install all necessary headers From: Mat Booth To: dev@apr.apache.org Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlt73DaRj70PmSlqoKLSZTZKTGsHB+t79uV1VQy7HFmJUF6h9u28Ev35xH7wKuelfqM7RtM Hi all, When using the install target of Makefile.win on Windows, I noticed that it does not install all the headers necessary for using the platform specific features of APR. Please see the patch to fix it below. --- Makefile.win.orig 2012-02-27 13:54:16.500000000 +0000 +++ Makefile.win 2012-02-27 13:56:07.906250000 +0000 @@ -161,11 +161,15 @@ @if NOT EXIST "$(PREFIX)\." mkdir "$(PREFIX)" @if NOT EXIST "$(PREFIX)\bin\." mkdir "$(PREFIX)\bin" @if NOT EXIST "$(PREFIX)\include\." mkdir "$(PREFIX)\include" + @if NOT EXIST "$(PREFIX)\include\arch\." mkdir "$(PREFIX)\include\arch" + @if NOT EXIST "$(PREFIX)\include\arch\win32\." mkdir "$(PREFIX)\include\arch\win32" @if NOT EXIST "$(PREFIX)\lib\." mkdir "$(PREFIX)\lib" copy CHANGES "$(PREFIX)\APR-CHANGES.txt" <.y copy LICENSE "$(PREFIX)\APR-LICENSE.txt" <.y copy NOTICE "$(PREFIX)\APR-NOTICE.txt" <.y xcopy include\*.h "$(PREFIX)\include\" /d < .a + xcopy include\arch\*.h "$(PREFIX)\include\arch\" /d < .a + xcopy include\arch\win32\*.h "$(PREFIX)\include\arch\win32\" /d < .a copy $(LIBSOSPATH)\apr-1.lib "$(PREFIX)\lib\" <.y copy $(LIBSOSPATH)\apr-1.pdb "$(PREFIX)\lib\" <.y copy $(LIBSOSPATH)\aprapp-1.lib "$(PREFIX)\lib\" <.y Best regards, Mat -- Mat Booth Software Engineer WANdisco, Inc. http://www.wandisco.com