Return-Path: 
 <dev-return-24657-apmail-apr-dev-archive=apr.apache.org@apr.apache.org>
X-Original-To: apmail-apr-dev-archive@www.apache.org
Delivered-To: apmail-apr-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 0A6A491AB
	for <apmail-apr-dev-archive@www.apache.org>;
 Mon, 30 Jan 2012 10:23:28 +0000 (UTC)
Received: (qmail 9703 invoked by uid 500); 30 Jan 2012 10:23:26 -0000
Delivered-To: apmail-apr-dev-archive@apr.apache.org
Received: (qmail 9287 invoked by uid 500); 30 Jan 2012 10:23:19 -0000
Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
List-Post: <mailto:dev@apr.apache.org>
List-Help: <mailto:dev-help@apr.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apr.apache.org>
List-Id: <dev.apr.apache.org>
Delivered-To: mailing list dev@apr.apache.org
Received: (qmail 9263 invoked by uid 99); 30 Jan 2012 10:23:08 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2012 10:23:08 +0000
X-ASF-Spam-Status: No, hits=0.7 required=5.0
	tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL
X-Spam-Check-By: apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Received: from [81.103.221.47] (HELO mtaout01-winn.ispmail.ntl.com)
 (81.103.221.47)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Jan 2012 10:23:00 +0000
Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35])
          by mtaout01-winn.ispmail.ntl.com
          (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP
          id
 <20120130102238.BVKP9217.mtaout01-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com>;
          Mon, 30 Jan 2012 10:22:38 +0000
Received: from cpc2-farn6-0-0-cust204.6-2.cable.virginmedia.com
          ([86.16.124.205]) by aamtaout01-winn.ispmail.ntl.com
          (InterMail vG.3.00.04.00 201-2196-133-20080908) with ESMTP
          id
 <20120130102238.FMGX10211.aamtaout01-winn.ispmail.ntl.com@cpc2-farn6-0-0-cust204.6-2.cable.virginmedia.com>;
          Mon, 30 Jan 2012 10:22:38 +0000
Received: by cpc2-farn6-0-0-cust204.6-2.cable.virginmedia.com (Postfix,
 from userid 1000)
	id A16B636199; Mon, 30 Jan 2012 10:22:36 +0000 (GMT)
From: Philip Martin <philip@codematters.co.uk>
To: Bojan Smojver <bojan@rexursive.com>
Cc: dev@apr.apache.org
Subject: Re: svn commit: r817809 - in /apr/apr/branches/1.4.x: CHANGES
 include/apr_hash.h tables/apr_hash.c
References: <20090922200625.5FFDB2388882@eris.apache.org>
	<1327907332.16813.19.camel@shrek.rexursive.com>
Date: Mon, 30 Jan 2012 10:22:36 +0000
In-Reply-To: <1327907332.16813.19.camel@shrek.rexursive.com> (Bojan Smojver's
	message of "Mon, 30 Jan 2012 18:08:52 +1100")
Message-ID: <87hazdqykz.fsf@stat.home.lan>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Cloudmark-Analysis: v=1.1 cv=R50lirqlHffDPPkwUlkuVa99MrvKdVWo//yz83qex8g=
 c=1 sm=0 a=dmETdrZ3I3YA:10 a=abzI0PYKx8oA:10 a=ZtYko7GbYTIA:10
 a=kj9zAlcOel0A:10 a=xGhkvXzhAAAA:8 a=mV9VRH-2AAAA:8 a=NLklZinEVWB6XOWH9bEA:9
 a=mrWcghmzkNE3cE1uoAkA:7 a=CjuIK1q_8ugA:10 a=nPMnL9xQAIMA:10
 a=88iI8knYSJUA:10 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117
X-Virus-Checked: Checked by ClamAV on apache.org

Bojan Smojver <bojan@rexursive.com> writes:

> On Tue, 2009-09-22 at 20:06 +0000, minfrin@apache.org wrote:
>> URL: http://svn.apache.org/viewvc?rev=817809&view=rev
>> Log:
>> The implementation of expand_array() in tables/apr_hash.c allocates
>> a new bucket array, without making any attempt to release the memory      
>> allocated for the previous bucket array. That wastes memory: if the     
>> hash table grows exponentially, this strategy wastes O(n) extra memory.
>> Use a subpool instead.
>> Submitted by: Neil Conway <nrc cs.berkeley.edu> 
>
> Somehow this commit never made it into trunk. It only exists in what is
> now 1.5.x. Anyone knows why?

It was reverted because it means the hash table data is not available in
pool cleanup handlers:

http://mail-archives.apache.org/mod_mbox/apr-dev/201001.mbox/%3C004001ca8fab$c7089b10$5519d130$@qqmail.nl%3E

-- 
Philip