Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A0C290B3 for ; Sun, 29 Jan 2012 23:00:18 +0000 (UTC) Received: (qmail 79388 invoked by uid 500); 29 Jan 2012 23:00:17 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 79245 invoked by uid 500); 29 Jan 2012 23:00:17 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 79237 invoked by uid 99); 29 Jan 2012 23:00:16 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Jan 2012 23:00:16 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of bojan@rexursive.com designates 150.101.121.179 as permitted sender) Received: from [150.101.121.179] (HELO beauty.rexursive.com) (150.101.121.179) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 29 Jan 2012 23:00:09 +0000 Received: from [10.1.120.20] (shrek.rexursive.com [10.1.120.20]) by beauty.rexursive.com (Postfix) with ESMTPSA id 021291A7DB6; Mon, 30 Jan 2012 09:59:47 +1100 (EST) Message-ID: <1327877987.16813.8.camel@shrek.rexursive.com> Subject: Re: svn commit: r1237078 - /apr/apr/trunk/tables/apr_hash.c From: Bojan Smojver To: Branko =?UTF-8?Q?=C4=8Cibej?= Cc: dev@apr.apache.org Date: Mon, 30 Jan 2012 09:59:47 +1100 In-Reply-To: <1327876677.16813.1.camel@shrek.rexursive.com> References: <20120128155422.BCF80238890B@eris.apache.org> <4F253CEB.5020002@apache.org> <4F2545DC.80708@apache.org> <1157242535.1012357368@rexursive.com> <1327851294.16813.0.camel@shrek.rexursive.com> <4F259CB0.1000204@apache.org> <1327876677.16813.1.camel@shrek.rexursive.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3 (3.2.3-1.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org On Mon, 2012-01-30 at 09:37 +1100, Bojan Smojver wrote: > I'm going to run some tests to see whether I get final hashes > that have similar upper bits. The test reveals that many upper bits are the same without the latest patch. With my latest patch, I get that fixed (i.e. the final hash is perturbed a lot better). So, I think I should apply it. PS. Because we are starting from the same starting point (the seed), it is not surprising that it takes a bit more to perturb the final hash better. The *33 is essentially <<5 + original value. So, it takes a few more cycles to get all 32 bits (my platform's unsigned int) perturbed. -- Bojan