apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Galić <i.ga...@brainsware.org>
Subject Re: [PATCH] pass --tag to libtool
Date Wed, 04 Jan 2012 23:57:32 GMT


----- Original Message -----
> 
> 
> ----- Original Message -----
> > Hi,
> >
> > although I have not investigated this further, libtool appears to
> > be
> > able to derive the language of the code that is being compiled from
> > the
> > name of the compiler in some cases, e.g. for gcc or g++.
> >
> > With clang and clang++ this does not seem to be the case, so that
> > --tag=CC needs to be passed explicitly.
> 
> Weird, I don't remember ever having had trouble compiling
> APR or APR-util with clang.
> 
> Anyway, +1 from me.
> 
> p.s.: Next time, please tag your thread as: [PATCH] so it
> can be identified easier.

Maybe also create a bug report in Bugzilla and attach the
patches there as well. (Marking it as PatchAvail)
Patches should be created against trunk (and potentially
against other branches, if it's not easily backportable)

Did I forget anything?

If not, I should store this in a template for next time :) 

> > I've attached patches that do just that. With both patches applied,
> > clang compiles and links apr 1.4.5 and apr-util 1.4.1 just fine;
> > they
> > pass their respective test suites afterwards, too.
> >
> >
> > Best regards,
> >
> > Elias Pipping
> 
> i
> 
> --
> Igor Galić
> 
> Tel: +43 (0) 664 886 22 883
> Mail: i.galic@brainsware.org
> URL: http://brainsware.org/
> GPG: 6880 4155 74BD FD7C B515  2EA5 4B1D 9E08 A097 C9AE
> 
> 

Mime
View raw message