apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bojan Smojver" <bo...@rexursive.com>
Subject Re: svn commit: r1236642 - in /apr/apr/trunk: tables/apr_hash.c test/testhash.c
Date Fri, 27 Jan 2012 23:54:09 GMT
------- Original message -------
> +    hash = ht->seed ^ ht->hash_func(key, &klen);

Actually, when I think about this, it will probably be inefective. If two 
keys produce the same hash, the xor-ed value against the seed will most 
certainly be the same as well. So, this won't actually do anything to stop 
the attack, except change which bucket attack picks.

So, we probably do need to seed the hash function instead.


View raw message