apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Philip Martin <phi...@codematters.co.uk>
Subject Re: svn commit: r817809 - in /apr/apr/branches/1.4.x: CHANGES include/apr_hash.h tables/apr_hash.c
Date Mon, 30 Jan 2012 10:22:36 GMT
Bojan Smojver <bojan@rexursive.com> writes:

> On Tue, 2009-09-22 at 20:06 +0000, minfrin@apache.org wrote:
>> URL: http://svn.apache.org/viewvc?rev=817809&view=rev
>> Log:
>> The implementation of expand_array() in tables/apr_hash.c allocates
>> a new bucket array, without making any attempt to release the memory      
>> allocated for the previous bucket array. That wastes memory: if the     
>> hash table grows exponentially, this strategy wastes O(n) extra memory.
>> Use a subpool instead.
>> Submitted by: Neil Conway <nrc cs.berkeley.edu> 
>
> Somehow this commit never made it into trunk. It only exists in what is
> now 1.5.x. Anyone knows why?

It was reverted because it means the hash table data is not available in
pool cleanup handlers:

http://mail-archives.apache.org/mod_mbox/apr-dev/201001.mbox/%3C004001ca8fab$c7089b10$5519d130$@qqmail.nl%3E

-- 
Philip

Mime
View raw message